From: Salvatore Ingala <salvatore.ingala@gmail•com>
To: Andrew Chow <achow101-lists@achow101•com>,
Bitcoin Protocol Discussion
<bitcoin-dev@lists•linuxfoundation.org>
Subject: Re: [bitcoin-dev] Taproot Fields for PSBT
Date: Mon, 28 Jun 2021 12:03:42 +0200 [thread overview]
Message-ID: <CAMhCMoF7N4BuXDz1cSDBLi5zH8c06uZ3T3gc750azFH3JagcNw@mail.gmail.com> (raw)
In-Reply-To: <795f917b-3883-1827-f39b-35123b500f36@achow101.com>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
Hi Andrew,
I just have a small suggestion on this proposal.
On Tue, 22 Jun 2021 at 23:29, Andrew Chow via bitcoin-dev <
bitcoin-dev@lists•linuxfoundation.org> wrote:
> | Taproot Leaf Script
> | <tt>PSBT_IN_TAP_LEAF_SCRIPT = 0x15</tt>
> | <tt><control block></tt>
> | The control block for this leaf as specified in BIP 341. The control
> block contains the merkle tree path to this leaf.
> | <tt><script> <8-bit uint></tt>
> | The script for this leaf as would be provided in the witness stack
> followed by the single byte leaf version.
>
So far, all the defined PSBT types had a relatively short keydata (not much
bigger than a couple of pubkeys).
I think that is a desirable property to keep, as it is often a reasonable
assumption that dictionary keys are not very large.
The control block as per BIP 341 can be up to 33 + 32*128 = 4129 bytes long.
Perhaps it would be better to split this into PSBT_IN_TAP_LEAF_SCRIPT
and PSBT_IN_TAP_LEAF_CONTROL_BLOCK (both with no keydata)?
Best,
Salvatore Ingala
[-- Attachment #2: Type: text/html, Size: 1549 bytes --]
next prev parent reply other threads:[~2021-06-28 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 21:22 Andrew Chow
2021-06-28 10:03 ` Salvatore Ingala [this message]
2021-06-28 16:04 ` Andrew Chow
2021-06-28 19:56 ` Salvatore Ingala
2021-07-08 20:06 ` Jeremy
2021-11-24 12:44 ` Sjors Provoost
2021-11-24 16:00 ` Greg Sanders
2021-11-24 16:08 ` Pieter Wuille
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMhCMoF7N4BuXDz1cSDBLi5zH8c06uZ3T3gc750azFH3JagcNw@mail.gmail.com \
--to=salvatore.ingala@gmail$(echo .)com \
--cc=achow101-lists@achow101$(echo .)com \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox