From: Mike Hearn <mike@plan99•net>
To: Gavin Andresen <gavinandresen@gmail•com>
Cc: Bitcoin Development <bitcoin-development@lists•sourceforge.net>,
Andreas Schildbach <andreas@schildbach•de>
Subject: Re: [Bitcoin-development] Feedback requested: "reject" p2p message
Date: Wed, 30 Oct 2013 09:24:44 +0100 [thread overview]
Message-ID: <CANEZrP0fU3M3o4ZgBormcuRvkipM0tjNG+StA_QC90UbcpxdGA@mail.gmail.com> (raw)
In-Reply-To: <CABsx9T25sqq5ps+ePgc+tH+ns8ygahpYztgga0DuqgoQj9tpzQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 998 bytes --]
> But if you are getting soft-forked recent versions of the reference
> implementation WILL alert you; see this code in main.cpp:
>
Perhaps I'm confused about how we're using the term soft fork. My
understanding is that this is where a new upgrade is designed to look valid
to old nodes, and if you don't upgrade you rely on the miner majority to
get you "back on track". For instance, P2SH was done this way - old nodes
that didn't upgrade during that transition believed all spends of P2SH
outputs were valid, even those spending someone elses coins.
In this case, the code you cite won't do anything because your client will
never reject a block during a soft-forking upgrade, even if it does
something that's supposed to be invalid or nonsensical.
If a new block version changes the serialization format or script language
or SIGHASH rules such that old clients reject the block, then they will end
up on a hard fork and the alerting code will trigger, which is correct and
as it should be.
[-- Attachment #2: Type: text/html, Size: 1403 bytes --]
next prev parent reply other threads:[~2013-10-30 8:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 0:34 Gavin Andresen
2013-10-26 1:01 ` Jean-Paul Kogelman
2013-10-26 2:00 ` Gavin
2013-10-26 4:32 ` kjj
2013-10-27 14:32 ` Mike Hearn
2013-10-27 14:39 ` Luke-Jr
2013-10-27 14:50 ` Mike Hearn
2013-10-30 17:13 ` Gregory Maxwell
2013-10-31 12:01 ` Mike Hearn
2013-10-27 22:52 ` Gavin Andresen
2013-10-28 2:52 ` kjj
2013-10-28 9:26 ` Andreas Schildbach
2013-10-28 9:32 ` Gregory Maxwell
2013-10-29 5:37 ` Gavin Andresen
2013-10-29 8:55 ` Warren Togami Jr.
2013-10-29 9:12 ` Peter Todd
2013-10-29 9:52 ` Mike Hearn
2013-10-29 10:14 ` Peter Todd
2013-10-29 11:38 ` Peter Todd
2013-10-29 12:32 ` Mike Hearn
2013-10-29 16:35 ` [Bitcoin-development] On soft-forks and hard-forks Peter Todd
2013-10-30 2:01 ` [Bitcoin-development] Feedback requested: "reject" p2p message Gavin Andresen
2013-10-30 8:24 ` Mike Hearn [this message]
2013-10-30 9:05 ` Mark Friedenbach
2013-10-30 10:26 ` Mike Hearn
2013-10-28 2:59 ` Luke-Jr
2013-10-28 3:02 ` Pieter Wuille
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANEZrP0fU3M3o4ZgBormcuRvkipM0tjNG+StA_QC90UbcpxdGA@mail.gmail.com \
--to=mike@plan99$(echo .)net \
--cc=andreas@schildbach$(echo .)de \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=gavinandresen@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox