From: Pieter Wuille <pieter.wuille@gmail•com>
To: Bitcoin Dev <bitcoin-dev@lists•linuxfoundation.org>,
Eric Voskuil <eric@voskuil•org>
Cc: libbitcoin@lists•dyne.org
Subject: Re: [bitcoin-dev] BIP151 protocol incompatibility
Date: Mon, 13 Feb 2017 00:47:38 -0800 [thread overview]
Message-ID: <CAPg+sBhDjVuN6=tdvUcSY5OCdJD7s3Jp90K1qx0iRX+2WppUQQ@mail.gmail.com> (raw)
In-Reply-To: <ba422d5e-8e96-3475-2a29-80d89fd67322@voskuil.org>
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
On Feb 12, 2017 23:58, "Eric Voskuil via bitcoin-dev" <
bitcoin-dev@lists•linuxfoundation.org> wrote:
The BIP151 proposal states:
> This proposal is backward compatible. Non-supporting peers will ignore
the encinit messages.
This statement is incorrect. Sending content that existing nodes do not
expect is clearly an incompatibility. An implementation that ignores
invalid content leaves itself wide open to DOS attacks. The version
handshake must be complete before the protocol level can be determined.
While it may be desirable for this change to precede the version
handshake it cannot be described as backward compatible.
The worst possible effect of ignoring unknown messages is a waste of
downstream bandwidth. The same is already possible by being sent addr
messages.
Using the protocol level requires a strict linear progression of (allowed)
network protocol features, which I expect to become harder and harder to
maintain.
Using otherwise ignored messages for determining optional features is
elegant, simple and opens no new attack vectors. I think it's very much
preferable over continued increments of the protocol version.
--
Pieter
[-- Attachment #2: Type: text/html, Size: 1833 bytes --]
next prev parent reply other threads:[~2017-02-13 8:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 5:18 Eric Voskuil
2017-02-13 8:47 ` Pieter Wuille [this message]
2017-02-13 9:36 ` Eric Voskuil
2017-02-13 10:07 ` Jonas Schnelli
2017-02-13 10:30 ` Eric Voskuil
2017-02-13 11:14 ` Jonas Schnelli
2017-02-14 19:54 ` Eric Voskuil
2017-02-14 20:58 ` Jonas Schnelli
2017-02-13 10:16 ` Matt Corallo
2017-02-13 10:54 ` Eric Voskuil
2017-02-13 11:11 ` Matt Corallo
2017-02-13 11:17 ` Eric Voskuil
2017-02-13 13:04 ` Matt Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPg+sBhDjVuN6=tdvUcSY5OCdJD7s3Jp90K1qx0iRX+2WppUQQ@mail.gmail.com' \
--to=pieter.wuille@gmail$(echo .)com \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
--cc=eric@voskuil$(echo .)org \
--cc=libbitcoin@lists$(echo .)dyne.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox