From: Matt Corallo <lf-lists@mattcorallo•com>
To: Anthony Towns <aj@erisian•com.au>
Cc: Bitcoin Protocol Discussion <bitcoin-dev@lists•linuxfoundation.org>
Subject: Re: [bitcoin-dev] Proposal for new "disabletx" p2p message
Date: Thu, 14 Jan 2021 00:39:16 -0500 [thread overview]
Message-ID: <DDE19B4D-9272-4645-8016-BDC377902751@mattcorallo.com> (raw)
In-Reply-To: <20210114053257.4ctg3qdvo7s44s72@erisian.com.au>
So we’d kill two birds with one stone if all bloom support was dropped. As far as I understand, precomputed filters are now provided via p2p connections as well.
Matt
> On Jan 14, 2021, at 00:33, Anthony Towns <aj@erisian•com.au> wrote:
>
> On Wed, Jan 13, 2021 at 01:40:03AM -0500, Matt Corallo via bitcoin-dev wrote:
>> Out of curiosity, was the interaction between fRelay and bloom disabling ever
>> specified? ie if you aren’t allowed to enable bloom filters on a connection due
>> to resource constraints/new limits, is it ever possible to “set” fRelay later?
>
> (Maybe I'm missing something, but...)
>
> In the current bitcoin implementation, no -- you either set
> m_tx_relay->fRelayTxes to true via the VERSION message (either explicitly
> or by not setting fRelay), or you enable it later with FILTERLOAD or
> FILTERCLEAR, both of which will cause a disconnect if bloom filters
> aren't supported. Bloom filter support is (optionally?) indicated via
> a service bit (BIP 111), so you could assume you know whether they're
> supported as soon as you receive the VERSION line.
>
> fRelay is specified in BIP 37 as:
>
> | 1 byte || fRelay || bool || If false then broadcast transactions will
> not be announced until a filter{load,add,clear} command is received. If
> missing or true, no change in protocol behaviour occurs.
>
> BIP 60 defines the field as "relay" and references BIP 37. Don't think
> it's referenced in any other bips.
>
> Cheers,
> aj
>
next prev parent reply other threads:[~2021-01-14 5:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 16:35 Suhas Daftuar
2021-01-13 6:40 ` Matt Corallo
2021-01-14 5:32 ` Anthony Towns
2021-01-14 5:39 ` Matt Corallo [this message]
2021-01-14 6:46 ` Anthony Towns
2021-01-19 19:19 ` Suhas Daftuar
2021-03-01 20:58 ` John Newbery
2021-03-01 23:11 ` Antoine Riard
2021-03-02 12:11 ` John Newbery
2021-03-02 22:42 ` Antoine Riard
2021-03-02 16:31 ` Anthony Towns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDE19B4D-9272-4645-8016-BDC377902751@mattcorallo.com \
--to=lf-lists@mattcorallo$(echo .)com \
--cc=aj@erisian$(echo .)com.au \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox