From: Tamas Blummer <tamas@bitsofproof•com>
To: Mike Hearn <mike@plan99•net>
Cc: Bitcoin Dev <bitcoin-development@lists•sourceforge.net>
Subject: Re: [Bitcoin-development] Missing fRelayTxes in version
Date: Thu, 20 Jun 2013 10:17:04 +0200 [thread overview]
Message-ID: <E9A1F9E4-0A9A-4B5F-98D2-585306EB99AA@bitsofproof.com> (raw)
In-Reply-To: <CANEZrP1MVKSNU92UrQ36sPCN0LNLKrVRXnfVwEZKhgoBFXatBA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2169 bytes --]
I agree that this can be deferred until there is an actual new field without any harm. But then remember to update the BIP37 too saying that it is optional only if flag added in BIPXX is not present.
Your argument is that this complexity is already there so why not preserve it. I think eliminating complexity (that has no benefit) strengthens the system.
Tamás Blummer
http://bitsofproof.com
On 20.06.2013, at 09:36, Mike Hearn <mike@plan99•net> wrote:
> Sure but why not do that when there's an actual new field to add? Does anyone have a proposal for a feature that needs a new version field at the moment? There's no point changing the protocol now unless there's actually a new field to add.
>
> Anyway I still don't see why anyone cares about this issue. The Bitcoin protocol does not and never has required that all messages have a fixed number of fields per version. Any parser written on the assumption it did was just buggy. Look at how tx messages are relayed for the most obvious example of that pattern in action - it's actually the raw byte stream that's stored and relayed to ensure that fields added in new versions aren't dropped during round-tripping. Old versions are supposed to preserve fields from the future.
>
>
>
> On Thu, Jun 20, 2013 at 9:30 AM, Tamas Blummer <tamas@bitsofproof•com> wrote:
> Hi Mike,
>
> The issue with the current parser is that those fields are conditionally optional on that there will be no subsequent fields added.
> If there will be further fields they will become manadory.
>
> Why not bump the version and parse the fields as mandatory from then on? This would be backward compatible and cleaner
> going forward.
>
> Tamas Blummer
> http://bitsofproof.com
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists•sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>
>
[-- Attachment #2: Type: text/html, Size: 9540 bytes --]
next prev parent reply other threads:[~2013-06-20 8:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 7:30 Tamas Blummer
2013-06-20 7:36 ` Mike Hearn
2013-06-20 8:17 ` Tamas Blummer [this message]
2013-06-20 8:31 ` Mike Hearn
2013-06-20 8:39 ` Tamas Blummer
2013-06-20 9:06 ` Pieter Wuille
2013-06-20 9:17 ` Mike Hearn
2013-06-20 10:37 ` Turkey Breast
2013-06-20 10:50 ` Mike Hearn
2013-06-20 10:52 ` Pieter Wuille
2013-06-20 10:58 ` Mike Hearn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E9A1F9E4-0A9A-4B5F-98D2-585306EB99AA@bitsofproof.com \
--to=tamas@bitsofproof$(echo .)com \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
--cc=mike@plan99$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox