From: Prayank <prayank@tutanota•de>
To: Bitcoin Dev <bitcoin-dev@lists•linuxfoundation.org>
Subject: [bitcoin-dev] Nuke *notify options from Bitcoin Core
Date: Sat, 1 Jan 2022 22:03:11 +0100 (CET) [thread overview]
Message-ID: <MsMS0F9--3-2@tutanota.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 2015 bytes --]
Hello World,
What?
Remove all *notify options from Bitcoin Core (full node implementation used by 99% nodes)
Or one of the below:
notifications.dat
not use system() in runCommand()
Use a new setting in settings.json file, notifypolicy which is 0 by default (restricted) and can be set to 1 (unrestricted)
Why?
They can help attackers in doing almost anything on machines running Bitcoin Core with some social engineering.
How?
Everything is explained several times in different issues, PRs etc. to different people including few reviewers who even NACKed a PR that would help in adding such options but with some documentation. I won't comment much about the reviewers but some of them were clueless about issue and how things work.
Example: Calling something misleading and ludicrous when you don't even know what works in Windows shortcut and could not share one example of financial application https://github.com/bitcoin/bitcoin/issues/23412#issuecomment-1003496126
TL;DR
https://github.com/bitcoin/bitcoin/pull/23395#issuecomment-956353035
https://github.com/bitcoin/bitcoin/issues/23412#issuecomment-970480769
To be honest, neither I have energy left to highlight the importance of these issues nor most of the people look interested in this space to address it. This email is a part of my efforts to share things with everyone which I even tried with documentation. There is something seriously wrong if few people including maintainers acknowledge the issues with *notify options but nobody wants to fix it or document it, I will leave it for people to form their own opinions about it.
Last but not least I was even asked to not review and comment in https://github.com/bitcoin/bitcoin/pull/23395 when I was just responding to others.
This will be helpful in my security project which was already shared in mailing list to highlight what users expect from developers and future of money, review process etc. and what is the ground reality.
Happy New Year
--
Prayank
A3B1 E430 2298 178F
[-- Attachment #2: Type: text/html, Size: 3092 bytes --]
next reply other threads:[~2022-01-01 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 21:03 Prayank [this message]
2022-01-01 22:57 ` Daniel Edgecumbe
2022-01-01 23:29 Prayank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MsMS0F9--3-2@tutanota.de \
--to=prayank@tutanota$(echo .)de \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox