public inbox for bitcoindev@googlegroups.com
 help / color / mirror / Atom feed
From: odinn.cyberguerrilla@riseup•net
To: "Srintuar" <srintuar@gmail•com>
Cc: bitcoin-development@lists•sourceforge.net
Subject: Re: [Bitcoin-development] Bug in key.cpp
Date: Mon, 5 May 2014 20:12:41 -0700	[thread overview]
Message-ID: <da34991a7a2db8f6f15401ed614cfe1e.squirrel@fulvetta.riseup.net> (raw)
In-Reply-To: <CACUQsLJwNo=GtcozCRpZU9PDDJE1fY-mnMomCUtf0WCsgGEnfA@mail.gmail.com>

You are right there is a bug in there.

But the value is not 25% I think.  Tinker some more. :-)

> I think i see a bug:
>
> line 273 of key.cpp
>
>         if (rec<0 || rec>=3)
>             return false;
>
> Afaict, 3 is a perfectly valid value, meaning 25% of sig-> key recoveries
> would fail erroneously...
> ------------------------------------------------------------------------------
> Is your legacy SCM system holding you back? Join Perforce May 7 to find
> out:
> &#149; 3 signs your SCM is hindering your productivity
> &#149; Requirements for releasing software faster
> &#149; Expert tips and advice for migrating your SCM now
> http://p.sf.net/sfu/perforce_______________________________________________
> Bitcoin-development mailing list
> Bitcoin-development@lists•sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bitcoin-development
>





  reply	other threads:[~2014-05-06  3:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06  2:42 Srintuar
2014-05-06  3:12 ` odinn.cyberguerrilla [this message]
2014-05-06  8:25   ` Pieter Wuille

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da34991a7a2db8f6f15401ed614cfe1e.squirrel@fulvetta.riseup.net \
    --to=odinn.cyberguerrilla@riseup$(echo .)net \
    --cc=bitcoin-development@lists$(echo .)sourceforge.net \
    --cc=srintuar@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox