From: Ali Sherief <ali@notatether•com>
To: "bitcoin-dev@lists•linuxfoundation.org"
<bitcoin-dev@lists•linuxfoundation.org>
Subject: [bitcoin-dev] Trying to patch Core ZMQ "rawtx" topic to only publish unconfirmed transactions: How?
Date: Fri, 26 Nov 2021 16:56:48 +0000 [thread overview]
Message-ID: <i1UxLDIyGhAt1KS5mHXaZ1cjhjEDd1bwVm-GZjrCRpye8z4O9zuwkw1CNa_UER12p79KknIKbT5hjjW5e0hwV0fWlB0kag6mHAF5f8K1y2k=@notatether.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2079 bytes --]
This has also been posted on Bitcointalk forum: https://bitcointalk.org/index.php?topic=5373341.msg58539261#msg58539261 I have republished it here hoping someone more knowledgeable can post some insight about this.
----
It appears that the ZeroMQ topic I'm listening to, "rawtx", not only emits a raw transaction when it appears on the mempool, but once it's already confirmed too.
This messes with my software, causing it to add txids, addresses, etc. a second time inside arrays (this means that the same transaction is received twice in total).
Array de-duping is not a viable solution long-term (because the array will quickly grow to be big eventually and then this has to happen every time a new element is added), so I'm trying to nip the problem from the source by instructing Core to only publish unconfirmed bitcoin transactions.
According to https://bitcoin.stackexchange.com/questions/52848/is-it-possible-to-configure-the-bitcoin-daemon-to-only-broadcast-unconfirmed-tra , it is not possible to configure this from a configuration or command-line option. The source code must directly be edited. But since the codebase has changed greatly, the proposed solution no longer works.
----
So basically, I know that something inside src/zmq/zmqnotificationinterface.cpp needs to be patched, but I'm not sure which function, or how to do it. Because I only need unconfirmed transactions to be published on ZeroMQ rawtx and not confirmed ones, it's one of the following functions that I need to patch for my own build:
CZMQNotificationInterface::TransactionRemovedFromMempool
void CZMQNotificationInterface::BlockDisconnected
Both of these call NotifyTransaction() method which I assume fires a message on "rawtx" channel.
In the Stack Exchange question I linked above, Jonas Schnelli suggested adding an `if (!pblock)` check, but that was several years ago and the function he was referencing no longer exists.
But I still wonder if the pblock check is still applicable in the present day (i.e. if it's indicating a block the transaction is inside).
- Ali Sherief
[-- Attachment #2: Type: text/html, Size: 3020 bytes --]
next reply other threads:[~2021-11-26 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 16:56 Ali Sherief [this message]
2021-11-29 9:32 ` 0xB10C
2021-11-29 14:10 ` LORD HIS EXCELLENCY JAMES HRMH
2021-11-29 14:13 ` Ali Sherief
2021-11-27 13:42 Prayank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='i1UxLDIyGhAt1KS5mHXaZ1cjhjEDd1bwVm-GZjrCRpye8z4O9zuwkw1CNa_UER12p79KknIKbT5hjjW5e0hwV0fWlB0kag6mHAF5f8K1y2k=@notatether.com' \
--to=ali@notatether$(echo .)com \
--cc=bitcoin-dev@lists$(echo .)linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox