From: Andreas Schildbach <andreas@schildbach•de>
To: bitcoin-development@lists•sourceforge.net
Subject: [Bitcoin-development] BIP70/71 issue, RFD
Date: Sun, 26 Jan 2014 22:11:47 +0100 [thread overview]
Message-ID: <lc3tm6$9ko$1@ger.gmane.org> (raw)
I'm experimenting with BIP70/71 (payment protocol) usage in face to face
payments (more on that soon).
I've excountered an issue with the protobuf format. Protobufs are not
self-delimiting. That means if you're reading from an undelimited
stream, you will read endlessly because you don't know how much to read.
The current BIP70 implementations probably work because they're reading
either from a file or from an HTTP resource which sets the
Content-Length header. Trouble is the Content-Length header is optional,
and also there are many kinds of streams that don't have this built-in
delimiting mechanism.
The Java protobuf API solves this by offering delimited I/O, like
payment.writeDelimitedTo(os);
This writes the size of the message as a varint before writing the data.
I don't know about protobuf implementations for other languages but I'd
expect them to offer something compatible.
However, this leading varint is an incompatible change and would need to
be added to the spec.
I specifically encountered this with PaymentMessage and PaymentACK, but
it might be a good idea to apply this to all messages if any. Open for
discussion.
next reply other threads:[~2014-01-26 21:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-26 21:11 Andreas Schildbach [this message]
2014-01-26 21:24 ` Mike Hearn
2014-01-26 21:32 ` Andreas Schildbach
2014-01-26 22:00 ` Mike Hearn
2014-01-26 22:14 ` Andreas Schildbach
2014-01-26 23:01 ` Mike Hearn
2014-01-27 2:05 ` Gavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='lc3tm6$9ko$1@ger.gmane.org' \
--to=andreas@schildbach$(echo .)de \
--cc=bitcoin-development@lists$(echo .)sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox