--- Log opened Mon May 09 00:00:18 2022
00:56 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
01:30 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
02:44 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
03:18 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
04:03 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
04:06 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
04:18 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
04:34 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
05:23 -!- Zeeshan [uid553646@id-553646.hampstead.irccloud.com] has joined #revault
05:32 < Zeeshan> Hey, I am a relatively new contributor in revaultd, so far the contributions I have made are quite small and didn't require stress testing of any form. But I might later have to run tests locally rather than relying on CI to pass. I am able to run the cargo tests but I wanted to know how do I run pytest on my local system, is there something that I need to install and setup before I run them? Thanks 
05:34 < darosior> Hey Zeeshan, welcome! See the tests' README https://github.com/revault/revaultd/tree/master/tests
05:36 < darosior> TL;DR:
05:36 < darosior> - We use pytest and a few Python deps
05:36 < darosior> - You need to setup a Postgre DB first. The easiest way is to just start a Postgre docker. For an instance of a docker one-liner: https://github.com/revault/coordinatord/blob/master/CONTRIBUTING.md#running-the-tests
05:37 < Zeeshan> Oh okay, I'll follow the readme, thanks :D
05:38 < darosior> Zeeshan: don't hesitate to note things that are unclear, so we can improve the doc for the following new contributors :)
05:39 < Zeeshan> Sure :)
06:01 < Zeeshan> Hey, I'm not sure but this could be an issue on my computer, but 
06:01 < Zeeshan> - I made a fresh clone of revaultd
06:01 < Zeeshan> - created a venv and installed the requirements
06:01 < Zeeshan> - run tests which does not require servers 
06:01 < Zeeshan> I assume that there is no requirement of Postgre for these tests and the tests will pass, when I run the tests, I seem to encounter missing file error. Am I missing some package or did I skip a step? 
06:06 < darosior> Hmm what file is it complaining about? have you compiled the test servers beforehand?
06:06 < darosior> A shortcut is to use this script: ./contrib/recompile_servers.sh
06:08 < Zeeshan> Oh, I'll try recompiling them
07:02 < Zeeshan> Okay I recompiled them and tested, the error remains 
07:02 < Zeeshan> FileNotFoundError: [Errno 2] No such file or directory: '/tmp/revaultd-tests-3bk_slvs/test_largewallets_1/regtest/.cookie'
07:03 < darosior> Ah, weird
07:03 < darosior> Can you share the entire backtrace using a paste site?
07:03 < darosior> Like https://0bin.net/
07:03 < Zeeshan> It is also looking for a missing file `bitcoind`
07:05 < Zeeshan> https://0bin.net/paste/g9hRv7y7#njFeT9VZkilpjBuITy2xR6VrK3KGrEiDMnJ1byoUFyY
07:11 < darosior> Ah, lol, ok it's because you are missing bitcoind :)
07:12 < darosior> Hmm the doc doesn't explicit it, it should
07:13 < darosior> You need to install bitcoind. The most straightforward way to do so is to DL a release there: https://bitcoincore.org/en/download/
07:13 < Zeeshan> Ohh okay, that makes sense xD
07:14 < darosior> And then either you "install" it (literally just copy paste it to /usr/local/bin, or you don't and you set BITCOIND_PATH=/your/path/to/bitcoind when running the functional tests
07:14 < Zeeshan> Should I edit the tests readme to add the detail I missed
07:15 < Zeeshan> I see, I'll try following your instructions and re-run the test
07:26 < darosior> Yeah a PR to clarify this would be very welcome!
07:26 < Zeeshan> Wait, do I need to run a full node on my computer, just want to clarify
07:58 < Zeeshan> Time-out: can't find [re.compile('bitcoind now synced')] in logs
07:58 < Zeeshan> Does this mean I need to download all the transaction data so far? That seems like a lot :/
08:13 -!- danielabrozzoni [~danielabr@2001:bc8:1828:379::1] has joined #revault
08:13 < danielabrozzoni> <Zeeshan> "Wait, do I need to run a full..." <- We only use regtest in the functional tests, so nope, you don't need a full node 🙂 
08:15 < danielabrozzoni> You don't even need bitcoind running on your system, the test framework takes care of starting various regtest nodes once you run the tests
08:29 < Zeeshan> I see, installing bitcoind fixed the missing file issue for me, although I have included --ignore for the server tests but it still seeks for Postgre 
08:29 < Zeeshan> Also as mentioned above I encounter the missing log error in the other tests
08:29 < Zeeshan> https://0bin.net/paste/Uo6s4nF-#LJGmLkylQGutaCbXFr-mfWbA1GaQT6tg+i5PniINwyR 
08:49 < darosior> Can you share the command you run as well please?
08:51 < darosior> Alright, it's due to missing skips!
08:52 < darosior> rndhouse has a commit for it in #389
08:52 < darosior> https://github.com/revault/revaultd/pull/389/commits/fcc2891babc2e781b5dda37d43450f4146755ce7
08:56 < Zeeshan> pytest tests/ -vvv -n4 --ignore tests/servers > dump
08:56 < darosior> This should have fixed it: https://github.com/revault/revaultd/pull/401
08:58 < Zeeshan> Oh great :D
08:58 < Zeeshan> I am not sure if this will fix the 'bitcoind now synced' problem though
08:58 < darosior> Exactly. I'm still thinking about this one
09:00 < darosior> You've compiled revaultd before running this, right?
09:00 < darosior> cargo build && pytest tests/ -vvv -n4 --ignore tests/servers
09:01 < Zeeshan> Yeah, lemme re-confirm it
09:01 < Zeeshan> okay I had, cargo build did not run again
09:26 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
18:44 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
21:29 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection]
21:31 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
22:06 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
22:43 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
23:54 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
--- Log closed Tue May 10 00:00:19 2022