--- Log opened Thu May 12 00:00:21 2022
01:27 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
02:02 -!- evanlinjin_ [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
02:36 < darosior> Alright, looks like i've made some good improvements to the CI. The long runtime of some Spend tests remains though
03:29 < Zeeshan> Hey, since I had an issue of getting functional tests running, I dug into the tests and commented `"bitcoind now synced"` check in every call of `wait_for_logs`, somehow this passed the two failing tests. Any idea about the issue? seems very odd to me
04:04 < darosior> Can  you tell us the steps you took? I can't reproduce 
04:19 < Zeeshan> Well the issue is that my tests are failing because the `wait_for_logs` times out looking for the synced message in the logs, but when I comment out that message from the list passed for `wait_for_logs`, my test passes. I ran `pytest tests/test_rpc.py` 
04:25 < darosior> I got that, but if i git clone a new repo, compile the servers, install the tests dependencies and run the tests i don't have any issue
04:26 < darosior> So i'm trying to think about what might have gone wrong, but it's very hard without any instructions to reproduce the issue..
04:26 < darosior> Hmm maybe the bitcoind version? It shouldn't be an issue, but i'll try with 23.0
04:27 < Zeeshan> I'll try it again from the scratch, and get back to you
04:30 < darosior> It's not an issue with 23.0, just tried
05:11 < Zeeshan> Here are the exact steps and error message that came up, am I missing  a step in the setup?
05:11 < Zeeshan> https://0bin.net/paste/SUZ0BThm#RIDawHNZnRMObx9B0nChNwWaM7JHTi36vFnBSIPod6m
05:17 < darosior> Thanks for the repro, looking into it
05:23 < darosior> I tested your repro and don't have any error 😭
05:24 < Zeeshan> oh no :(
05:24 < darosior> Alright, let's try something
05:24 < darosior> Maybe your machine is slower, mine is pretty beefy
05:24 < Zeeshan> ohh, so it's timing out?
05:25 < darosior> The error is a time out, yes. It's named TimeoutError for a reason :)
05:25 < Zeeshan> right
05:25 < darosior> Can you try: `cargo build --release && REVAULTD_PATH=$PWD/target/release/revaultd pytest tests/test_rpc.py -k getinfo`
05:26 < darosior> Building with optimizations should make revaultd significantly faster so that it should pass this test without issue even on a slower machine
05:30 < Zeeshan> Still timing out :(
05:31 < Zeeshan> Any way I can disable the time out and run it for a few mins instead?
05:35 < darosior> You can increase the timeout duration. But something clearly is wrong there
05:36 < darosior> TIMEOUT=120 for 2mins for instance
05:36 < darosior> When you run it by hand with the test data directory, don't you you see the "bitcoind now synced"?
05:37 < Zeeshan> On the bitcoind process? No
05:37 < Zeeshan> or do you mean revaultd? let me check
05:38 < Zeeshan> checked in `/tmp/revaultd-tests-81eoy5e5/test_getinfo_1/log`, no mention of `bitcoind` in the file
05:50 < darosior> This log is printed by revaultd
05:50 < darosior> Can you try manually? Like i described the other day
05:50 < darosior> bitcoind -datadir=/tmp/..... on one side and `revaultd --conf /tmp/....` on the other
05:51 < Zeeshan> yeah let me run it
05:54 < Zeeshan> `[1652360028][revaultd::bitcoind::poller][INFO] bitcoind now synced.`
05:54 < Zeeshan> log exists
06:05 < darosior> I'm out of suggestions tbh :/
06:06 < darosior> Maybe try with a large timeout? Just to check if that's the cause
06:06 < darosior> What's your system?
06:08 < Zeeshan> `HP Pavilion Gaming 10th Gen Intel Core i5 Processor` running ` Ubuntu 20.04.3 LTS`
06:16 < Zeeshan> I added `TIMEOUT = 120` at the top of the file after the import, and the tests passed xD
07:03 < Zeeshan> I ran `pytest tests/ -vvv -n6 --ignore tests/servers` and it did not terminate for 32 mins, how long does it usually take to run these tests? 
07:41 < darosior> On my machine, about 5mins with -n 20 
07:41 < darosior> But again my laptop is pretty beefy :p It shouldn't take more than 20mins with -n10 i'd say
07:41 < darosior> But if you can't run test_getinfo in 60 seconds.. Idk
08:56 < Zeeshan> okay I'll leave it on overnight and see if it actually ends
--- Log closed Fri May 13 00:00:22 2022