--- Log opened Tue May 17 00:00:26 2022 00:34 < darosior> edouard[m]: ping for the tiny specs PR 00:34 < edouard[m]> 👍️ 00:38 < darosior> Cool 02:17 < darosior> #408 is the last thing you need right edouard[m]? 02:17 < darosior> Or is there still stuff to do on the GUI? 02:19 < edouard[m]> It is the last required stuff 02:19 < edouard[m]> I am finishing the PR using it on the gui side 02:19 < edouard[m]> After I can add this if we want: https://github.com/revault/revault-gui/pull/329 02:24 < darosior> Let's try to finish the necessary stuff so we can make Kevin and Bea test aquarium before they fly 02:27 < darosior> I'm going to review #408, if you are done before i am can update all binaries to https://github.com/revault/revault_net/pull/85 and test on revaultd if i didn't break everything last minute? I'll do it after otherwise 02:29 < edouard[m]> ok 02:47 < edouard[m]> RevaultTransaction::from_raw_psbt is useless for the gui 02:47 < edouard[m]> I would kill to have a from_psbt 02:48 < edouard[m]> but we dont have time 03:01 < darosior> It's the entire point of not providing one :) 03:17 < darosior> Wow i had forgotten how dark is the Spend tx management code 03:21 < Zeeshan> Hey I need to make a test for `update_spend_tx`, is there a simple test that's there from where I can understand how the tests work? 03:24 < darosior> Hey Zeeshan, yeah let me check 03:28 < darosior> I think these two https://github.com/revault/revaultd/blob/6cb59135052235b3f0ab36b3591c30d58ad24ef4/tests/test_misc.py#L16-L49 and this one https://github.com/revault/revaultd/blob/6cb59135052235b3f0ab36b3591c30d58ad24ef4/tests/test_misc.py#L108-L144 are good introductions to how the testing framework operates. See the fixtures to see where the 03:28 < darosior> tests start from https://github.com/revault/revaultd/blob/master/tests/fixtures.py. 03:29 < darosior> Unrelated: the "chain" tests may be interesting if you are curious about Bitcoin edgecases :) https://github.com/revault/revaultd/blob/master/tests/test_chain.py (those mainly exerces the behaviour of revaultd under different reorg conditions) 03:31 < darosior> For the Spend transaction management flow, no better introduction than this one: https://github.com/revault/revaultd/blob/6cb59135052235b3f0ab36b3591c30d58ad24ef4/tests/test_spend.py#L21. This schemas might be helpful too https://github.com/revault/revaultd/blob/master/doc/API.md#manager-flow 03:32 < darosior> test_update_spend_tx may be a very small subset of test_spendtx_management that specifically exercises that signatures are merged 04:33 < Zeeshan> Hey I was going through `test_largewallets` and we are calling `"getdepositaddress"` multiple times for the same stakeholder, Won't it return the same address? or is a new address generated for the wallet each time to ensure security? 04:38 < Zeeshan> Also I'm not sure if this is really an improvement, but sometimes when parameters are not obvious, we can use keyword arguments to make it explicit, just a thought :D 04:38 < Zeeshan> https://www.irccloud.com/pastebin/VBGVdybZ/ 04:47 < darosior> Hmm iirc the JSONRPC server doesn't handle key-value args... 😅 04:49 < darosior> Regarding the new address. A new one could be generated each time to ensure *privacy* (not security, although those might be indirectly related). But in our case it doesn't make a lot of sense: you can already grow a cluster of a Revault deployment pretty easily 04:49 < darosior> So we just create a new address once one is actually used 04:50 < darosior> See https://en.bitcoin.it/wiki/Privacy for a good introduction to this topic 04:51 < darosior> Re your last message, yeah feel free to do that, it's a good practice 04:58 < Zeeshan> Oh right, privacy is the correct term. Avoids tracing transactions to the same address, my bad 05:33 < darosior> edouard[m]: if you really want the flow chart in, we need to test it first so it should be ready pretty soon. I've tested the msg serialization changes on all binaries and suggested a patch to your PR, i guess you saw that? How is it going on the GUI side? 05:34 < edouard[m]> The PR on gui side for #408 is ready, I have applied locally your patch on #408 and I am testing it 05:34 < darosior> Cool 05:51 < edouard[m]> you patch use Hashmap::into_values, it did not break on my side but it breaked the ci because it was introduce in rust 1.54 05:52 < darosior> arf 05:53 < darosior> idk, then use a dirty clone or better an `IntoIterator` if we don't need to move the vault structure. With the latter you can then use .values() that must be there in 1.48? 05:55 < edouard[m]> yes I am searching 06:00 < darosior> I'm setting up aquarium 06:48 < darosior> We should probably have '>/dev/null' be part of the aliases on aquarium 07:02 < edouard[m]> I saw the error, the pb comes from the hasmap with the values method that returns the list of vaults in random order 07:02 < edouard[m]> I will fix the test 07:31 < darosior> So i extensively tested w/o cosigs and w/o coord 07:31 < darosior> Would be helpful to test with 08:04 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault 08:33 < darosior> edouard[m]: any update? 08:34 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection] 08:35 < edouard[m]> #408 is fixed 08:35 < darosior> Cool, will have a look 08:43 < darosior> Ok, i think revault_tx, revaultd_net, revaultd, miradord, cosignerd and coordinatord are all ready to be tagged. I'll tag them first thing tomorrow morning if there has been no bug found until then. 08:45 -!- kanzure_ [~kanzure@user/kanzure] has joined #revault 08:48 < darosior> I'll merge the dev branch to master in aquarium too. Is that alright for the GUI edouard[m]? 08:50 -!- Netsplit *.net <-> *.split quits: kanzure 08:50 < edouard[m]> You will merge in master after all the new release tag are in aquarium.py right ? 08:55 < darosior> I think it's fine to merge in master now, if someone happened to come tonight on master everythin should work as expected 08:56 < darosior> Since the master branch of each repo shouldn't move anymore 08:56 < darosior> Which is why i ask for the GUI, because i know for all the other ones 08:59 < edouard[m]> GUI will move last time more, I ping you in 15mn 09:00 < edouard[m]> lets move add-tx-flowchart to next release, It will be better with feedbacks from the team 09:01 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault 09:05 < edouard[m]> aquarium dev must be modified 09:20 < edouard[m]> darosior (IRC): gui ready on master 09:21 < edouard[m]> aquarium dev does not have the good binaries versions 09:21 < darosior> Cool 09:21 < darosior> I've updated it to master 09:50 < darosior> Oh fuck i forgot to update the alias 09:50 < darosior> Oh well 10:15 -!- kanzure_ is now known as kanzure 10:53 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 12:13 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault 12:55 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 18:07 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault 18:36 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 18:59 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault 19:52 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 21:47 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault 22:18 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds] 22:34 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault --- Log closed Wed May 18 00:00:26 2022