--- Log opened Wed May 18 00:00:26 2022
01:50 < darosior> Still no issue with aquarium?
02:08 < edouard[m]> I have got an error
02:21 < darosior> Ah!
02:21 < darosior> I'm in the process of tagging releases, tell me more
02:22 < darosior> https://i.makeagif.com/media/11-14-2016/1X2IX2.gif
02:22 < edouard[m]> [1652865283][revault_gui::daemon::client][ERROR] method getspendtx failed: Json(Error("missing field `deposit_outpoints`", line: 1, column: 6045))
02:22 < edouard[m]> very weird
02:22 < edouard[m]> I guess it is the jsonrpc client
02:23 < darosior> Did you manage to bypass the screen where you select coins?
02:24 < darosior> So i can still tag the libraries and the servers
02:25 < edouard[m]> No I am selecting coins
02:29 < darosior> Weird, can you reproduce it reliably? I didn't encounter this
02:29 < darosior> What coordinator are you using
02:30 < darosior> Ooh this makes me thing the msg serialiation should be updated in the dummy coordinator too!
02:30 < darosior> https://github.com/revault/aquarium/blob/9ab71d07c60cd7e3f43b7df751426e261757bd84/test_framework/coordinatord.py#L192-L202
02:33 < edouard[m]> its not a coordinatord problem
02:41 < edouard[m]> revault-cli gives me the correct response from revaultd
02:41 < edouard[m]> which is logical because the tests would have catch it
02:43 < edouard[m]> I think gui failed to deserialize a vec of outpoint
02:43 < edouard[m]> I dont understand why you dont have the error
02:44 < edouard[m]> what version of rust you are using ?
02:54 < darosior> rustc 1.60.0 (7737e0b5c 2022-04-04)
03:01 < darosior> edouard[m]: i guess you didn't update your revaultd
03:01 < darosior> It's obviously the change i last merged, the patch in which you modified the result of getspendtx
03:01 < darosior> The GUI client must expect the new result
03:01 < darosior> And the revaultd must give it the old one
03:02 < edouard[m]> actually the revaultd is giving the new one
03:02 < edouard[m]> but maybe the gui does not have the good revaultd commit
03:04 < darosior> "missing field `deposit_outpoints`" sounds a lot like the GUI is expecting a "listspendtx" resource (we should rename that btw)
03:23 < darosior> edouard[m]: did you spot the bug?
03:26 < edouard[m]> no
03:26 < edouard[m]> It's a nightmare
03:26 < edouard[m]> you dont have it on aquarium master ?
03:26 < edouard[m]> you did a spend ?
03:27 < darosior> I did do a Spend but it was before merging your PR
03:28 < edouard[m]> can you try on aquarium master
03:29 < darosior> Yeah i just have one last release PR. Let's do that: i make the PR for miradord and we swap, i'll take a look to aquarium and you make sure i didn't forget anything in all my release PRs :)
03:29 < edouard[m]> I think I found
03:29 < edouard[m]> please let me 10mn more
03:29 < darosior> Sure
03:30 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
03:33 < edouard[m]> Ok I have the bug and the fix
03:33 < edouard[m]> You can tag the servers
03:33 < darosior> What was it?
03:34 < edouard[m]> gui relies on struct from revaultd commands
03:34 < edouard[m]> to deserialize correctly jsonrpc response 
03:34 < darosior> Yeah so it was that: the GUI was up to date but not the revaultd?
03:35 < edouard[m]> but sometimes the json is different because revaultd::jsonrpc::api introduce some middle key
03:35 < darosior> Ah
03:35 < darosior> Ok
03:35 < darosior> Oh f. 
03:35 < darosior> My plane is sooner than i expected
03:35 < edouard[m]> I will increase the robustness by checking the mapping
03:35 < darosior> I won't have time to release this morning
03:36 < darosior> I need to pack and run
03:36 < edouard[m]> ok good flight
03:36 < darosior> I published net and tx
03:37 < edouard[m]> cool
06:54 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
08:55 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
11:34 < edouard[m]> coordinatord ci failed
11:37 < darosior> Arf
16:47 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
17:18 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 240 seconds]
20:23 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
22:30 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection]
22:32 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
22:35 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Client Quit]
--- Log closed Thu May 19 00:00:27 2022