--- Log opened Mon Jun 20 00:00:57 2022
02:17 < darosior> Zeeshan: some cases that could be interesting to have in the functional test for manual CPFP:
02:17 < darosior> - manually CPFP a single Unvault
02:17 < darosior> - manually CPFP a single Spend
02:17 < darosior> - manually CPFP a single Spend along with multiple Unvaults
02:17 < darosior> - manually CPFP a single Unvault along with multiple Spends
02:17 < darosior> - manually CPFP a Spend and an Unvault but actually it wasn't necessary: they get mined without the CPFP transaction, which eventually gets included in another block. (This is to make sure the software doesn't assume the CPFP tx is always included in the same block as its parents, although it is the common case.)
02:17 < darosior> - manually CPFP with a lower package feerate (do you know what we refer to as a package?). We shouldn't allow this (as it's just a waste. Same for CPFP with an equal package feerate, or with only a marginal increase.
02:17 < darosior> - check the parameters are sanitized (give it an invalid txid, or a valid-but-unknown txid)
02:18 < Zeeshan> Okay I'll implement these, thank you :D
06:57 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
10:55 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Remote host closed the connection]
11:00 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has joined #revault
11:50 -!- evanlinjin [~evanlinji@gateway/tor-sasl/evanlinjin] has quit [Ping timeout: 268 seconds]
18:51 -!- blkncd [sid505676@id-505676.helmsley.irccloud.com] has quit [Ping timeout: 248 seconds]
18:59 -!- blkncd [sid505676@helmsley.irccloud.com] has joined #revault
--- Log closed Tue Jun 21 00:01:01 2022