--- Log opened Fri Jul 01 00:00:09 2022
04:31 < Zeeshan> Trying to CPFP a transaction with lower feerate leads to a panic, I'm not sure what the threshold must be on the feerate for the CPFP to be triggered. `CpfpableTransaction` use `max_feerate()` to determine if they must be CPFPed or not, do what would be the similar counterpart for it? 
04:32 < Zeeshan> Also, suppose a transaction has already been mined and I try to CPFP it, since the transaction is not present in the mempool, how will I verify if the CPFP actually took place, apart from the log?
04:38 < darosior> Hmm
04:41 < darosior> I'd say there is no need for a threshold since it's manually triggered. Even if the user is bumping by only 1sat/vb, we should allow them to do so
04:42 < darosior> If the transaction is mined we shouldn't let them CPFP i guess?
04:50 < Zeeshan> Okay, then I misunderstand the test cases scenarios you had mentioned 
04:50 < Zeeshan> manually CPFP a Spend and an Unvault but actually it wasn't necessary: they get mined without the CPFP transaction, which eventually gets included in another block. (This is to make sure the software doesn't assume the CPFP tx is always included in the same block as its parents, although it is the common case.)
04:50 < Zeeshan> manually CPFP with a lower package feerate (do you know what we refer to as a package?). We shouldn't allow this (as it's just a waste. Same for CPFP with an equal package feerate, or with only a marginal increase.
04:52 < darosior> What did you misunderstand?
04:53 < Zeeshan> I thought we must be able to CPFP a transaction even if it has mined in the scenario 1
04:54 < Zeeshan> Although that doesn't make sense
--- Log closed Sat Jul 02 00:00:09 2022