--- Log opened Mon Aug 29 00:00:03 2022
01:49 < darosior> edouard[m]: do you think we can land #17?
02:11 < edouard[m]> ćan you rebase it on master ?
02:11 < edouard[m]> difficult to see the scope of the change
02:32 < darosior> Last 4 commits, 9d0c68dae34f96a96d318f75cbbb5dbefffdd3d8 and below are part of master
02:32 < darosior> (ie, it is rebased)
02:36 < edouard[m]> good for me
02:36 < darosior> Cool
03:54 < darosior> edouard[m]: how about this heuristic for change detection: for any transaction that spends existing coins, go through its outputs. Any output that is not in the coins table (or otherwise considered received) is necessarily sent.
03:55 < edouard[m]> ACK
03:55 < edouard[m]> (I was afraid of race pb, but coin in table can be unconfirmed)
04:07 < darosior> There might be a race. In this case it can also be implemented on the side of the Bitcoin interface, and you can `listsinceblock` since the block before the spend transaction. This way, you are sure there won't be any race
04:09 < darosior> Also keep in mind that not all inputs may be from our wallets
09:49 -!- danielabrozzoni [~danielabr@2001:bc8:1824:bc3::1] has joined #revault
09:49 < danielabrozzoni> <darosior> "Also i've started thinking about..." <- Tbh you're not the first one (you're the second one! :D) that needs CS but doesn't want to pull the entirety of BDK for that... I was wondering, would you be more open to using BDK's implementation, if we found a way for you to only pull the CS code?
09:50 < darosior> danielabrozzoni: yes. But now i'm not sure if i don't want to also get oldest-first inside the CS (so you re-cycle your coin behind a CSV for free)
09:51 < darosior> So, yes, in principle (if it has a reasonable MSRV and no deps, but i don't see why there would be deps there so all good), but we might end up not using it because we didn't make design choices yet
09:51 < darosior> Btw we should talk about what we are doing at some point, been told you've been thinking about it too
09:51 < darosior> Maybe in the Azores? You are coming right?
09:54 < danielabrozzoni> Could be possible if I segregate the CS code into a different repo... I have to think more about it, but it's doable. We're doing heavy changes to the code rn tho, so I can't promise I can get it done quickly :)
09:54 < danielabrozzoni> Even if you don't end up using it, I'm sure it can be useful for someone else
09:54 < danielabrozzoni> But yeah let's talk! I'm coming in the Azores, yep 🙂 
10:07 < darosior> Yeah i believe it would be helpful as a library. People even asked for a libcoinsselection to be shipped with Core's CS. A Rust lib would make a lot of sense IMO
--- Log closed Tue Aug 30 00:00:05 2022