--- Log opened Thu Nov 10 00:00:13 2022
00:05 -!- gnusha [~gnusha@user/gnusha] has joined #revault
00:05 -!- Topic for #revault: Revault development discussions.  https://github.com/revault/ . Specs at https://github.com/revault/practical-revault . Try out the demo at https://github.com/revault/aquarium .
00:05 -!- Topic set by darosior [~darosior@194.36.189.246] [Tue Aug 17 01:27:05 2021]
00:05 [Users #revault]
00:05 [@ChanServ        ] [ darosior  ] [ gnusha      ] [ michaelfolkson] [ Zeeshan] 
00:05 [ danielabrozzoni1] [ edouard[m]] [ MatrixBot123] [ mjdietzx__    ] 
00:05 -!- Irssi: #revault: Total of 9 nicks [1 ops, 0 halfops, 0 voices, 8 normal]
00:06 -!- Channel #revault created Thu Jun 24 08:37:39 2021
00:08 -!- Irssi: Join to #revault was synced in 190 secs
06:08 < darosior> i think i found a bug
06:08 < darosior> Using the installer i could create wsh(or_d(pk([7626aa40]xpub661MyMwAqRbcGJCrBJoJTXUWyo37qbLKg6n2wMwcm4b78VWgquWecxEC4RBtnzhuxdU7oahQ8KuPPRkfMkrUUc36kqyxNa7d4L12gXrKLo5/0/*),and_v(v:pkh(xpub6FFeWUoqGhm8ncKMRKQoBcNrU7XDvsdrcCwPWw1yTBY6jYCth4xNmabPrQHoqZ9hkRZg7jPG4Rja23GXWSiNovN7uLfAzs1xfohiL7iyhhh/0/*),older(18))))#wkgth7yw
06:08 < darosior> Oh wait no worries. The bug is in the installer. I think it's because of the keys.
06:09 < darosior> edouard[m]: even for testnet we set the key as an xpub in the installer
06:09 < darosior> Oh maybe the bug is in the config network check
06:14 < darosior> Yes, it should be checked in the config
06:15 < edouard[m]> which branch are you using ? 
06:15 < darosior> Ooooh i got it
06:15 < darosior> The installer is not using from_file on the Config struct. So the sanity check isn't applied.
06:16 < darosior> https://github.com/revault/minisafe/pull/24 rebased on the gethistory branch itself rebased on master.
06:16 < darosior> edouard[m]: Have you ever tried making a testnet config?
06:16 < darosior> You should call test() on the config after creating it
06:17 < edouard[m]> all my work was done with testnet config
06:17 < darosior> Wasn't it regtest?
06:17 < edouard[m]> no testnet
06:17 < darosior> Then you used tpubs?
06:17 < darosior> I tried using xpubs
06:17 < darosior> And i don't get any error
06:17 < darosior> And then the finalization of the config breaks
06:17 < edouard[m]> I used xpubs, because that what i received from ledger and specter
06:17 < darosior> wtf
06:18 < darosior> Let's jump on a call
07:59 < darosior> Hmmm CI failed on master following your latest merge https://github.com/revault/minisafe
07:59 < darosior> Looks like it's spurious
08:05 < edouard[m]> what means your last comment https://github.com/revault/minisafe/pull/84#issuecomment-1310485288
08:05 < edouard[m]> should the minisafe-gui freeze the user view until rescan then ?
08:06 < edouard[m]> Or is it still ok to let run rescan in background ?
08:47 < darosior> No no just that the alternative that i propose in the OP is wrong
--- Log closed Fri Nov 11 00:00:14 2022