--- Log opened Thu Nov 17 00:00:20 2022
05:53 < darosior> edouard[m]: what was the issue with the Ledger not recognizing the inputs?
06:46 < edouard[m]> I think it does not know if it is our input, does the bip32_derivation psbt field is filled with the ledger fingerprint ?
06:47 < edouard[m]> https://docs.rs/bitcoin/latest/bitcoin/util/psbt/struct.Input.html#structfield.bip32_derivation
06:47 < edouard[m]> same for output
06:52 < edouard[m]> https://github.com/revault/minisafe/blob/master/src/commands/mod.rs#L335
06:53 < edouard[m]> seems that the bip32_derivation is added to input
06:53 < edouard[m]> but not to output
06:53 < edouard[m]> I need to check my ledger client
07:50 < darosior> edouard[m]: fyi i'm going to merge this https://github.com/revault/minisafe/pull/96
07:51 < darosior> Yes for outputs i know and had an open issue about it. But for inputs it's surprising. Does it need more information?
07:51 < darosior> Would be nice to test that soon so if it's an issue with the new Ledger Bitcoin app we can tell Salvatore
07:55 < darosior> Also i'm proceeding with the renaming
08:25 -!- Guest154444 [~Guest1544@87-231-29-23.rev.numericable.fr] has joined #revault
08:49 < edouard[m]> ok
08:53 -!- Guest154444 [~Guest1544@87-231-29-23.rev.numericable.fr] has quit [Quit: Client closed]
12:59 < edouard[m]> with the bip32_derivation in outputs that you added, the ledger recognize the change output
13:00 < edouard[m]> the funny thing is the ledger then does not ask you to verify change output, it only displays the ougoing outputs
--- Log closed Fri Nov 18 00:00:20 2022