--- Day changed Wed Sep 05 2018 02:22 < ariard> Ah sorry just back now to stuff, reviewing #147 ! 03:00 < ariard> BlueMatt : have you look into c-lightning or lnd to have a quick look on their error types 03:00 < ariard> ? 03:02 < BlueMatt> I have not 03:04 < ariard> ok doing it right now for #147 03:04 < BlueMatt> I'm off to bed, will take a look tomorrow morning! 03:12 < ariard> okay I too will not last, should be available tomorrow around 20:00 UTC 05:44 < Blackwolfsa> I have a random question on the error types. What is the reason for using macro's in handling errors? 05:44 < Blackwolfsa> Would it not be simpler to just implement the error trait and conversions between error's? 08:03 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-elhaljwlhmjxitxb] has joined #rust-bitcoin 12:02 < andytoshi> Blackwolfsa: what macrors? 12:13 < Blackwolfsa> @andytoshi Here is an example : https://github.com/rust-bitcoin/rust-lightning/blob/master/src/ln/peer_handler.rs#L330-L354 12:17 < andytoshi> ah, i'm not sure -- you could replace that function with a `From` impl and use the standard `try!` macro (or `?` or whatever) .. though that would ensconsce this potentially-logging conversion as the only way to convert between these error types 12:17 < andytoshi> it would also lose line/file information but it looks like we're not using that here 12:19 < Blackwolfsa> I spotted quite a few of them scattered through the code. But you have to manually do the from conversion. So can do everything you currently do in the macro in the from conversion 12:19 < Blackwolfsa> at least as far as I have it 15:15 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 16:26 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-elhaljwlhmjxitxb] has quit [Quit: Connection closed for inactivity] 21:38 -!- Fabian_ [~Mutter@2a02:8109:98c0:539c:dcf0:c93c:1e66:ca47] has joined #rust-bitcoin 21:41 -!- Fabian_ [~Mutter@2a02:8109:98c0:539c:dcf0:c93c:1e66:ca47] has quit [Client Quit]