--- Day changed Tue Sep 11 2018
00:51 < ariard> BlueMatt: I think we also have to add set_their_delayed_payement_base_key in ChannelMonitor and keep it
00:52 < ariard> because we need it to build penalty redeemscript of remote HTLC transactions, and so my commit on check_spend_remote_transaction is currently wrong
01:51 < dongcarl> BlueMatt: gotcha, how is he usually reached?
02:16 < ariard> updated with it on #163, it solved the building of redeemscript
14:31 -!- itaseski [~itaseski@213.135.178.20] has joined #rust-bitcoin
14:38 < BlueMatt> dongcarl: try ;;later tell TamasBlummer
14:38 < BlueMatt> dunno when he was last here but he used to show up here and there
14:38 < BlueMatt> ariard: wouldnt surprise me
14:39 < BlueMatt> sorry I've been a bit slow on review last few days, been desperately trying to rewrite the htlc tracking in channelmanager :(
14:39 < BlueMatt> huge pile of refactors all at once :(
14:39 < BlueMatt> dongcarl: otherwise email
17:48 < andytoshi> BlueMatt: gonna release 0.14.2 of rust-bitcoin today (address serde serialization #159, nothing else) and rust-secp 0.11.2 (fixes endianness issue)
17:48 < andytoshi> then start reviewing stuff for 0.15
18:05 < andytoshi> BlueMatt: https://github.com/rust-bitcoin/rust-bitcoin/pull/167 0.14.2
18:05 < BlueMatt> andytoshi: cool. Sorry've been a bit mia...huge refactors coming down the pipe for rust-lightning that I just need to focus and churn though
18:06 < BlueMatt> :(
18:06 < BlueMatt> sadly not ones I want to do, but kinda have to :/
18:07 < andytoshi> thanks! https://github.com/rust-bitcoin/rust-secp256k1/pull/69 is rust-secp 0.11.2
18:07 < andytoshi> aw :(
18:07 < andytoshi> that's no fun. but sometimes it's cool to see the whole program with fresh eyes and find architectural optimizations
18:08 < andytoshi> i had to do this at blockstream with the blocksigner recently to deal with a rare-but-round-killing bug related to messages arriving out of order, which was a huge chore but there were fun parts
18:08 < BlueMatt> heh, well i made some assumptions spec says I cant make (and for good reason), so have to refactor a bunch of things
18:08 < BlueMatt> is a decent opportunity to clean a few things up and in the end it'll have fewer panic!()s lying around, so thats good
21:47 < sgeisler> Hi, what's the state of bitcoin_hashes? Will there be a published version soon?
21:56 < andytoshi> sgeisler: oh lol oops i forgot about it
21:57 < andytoshi> i need BlueMatt  to merge the existing PRs then i think there are 2 or 3 more minor ones
21:57 < andytoshi> then i can publish a release...we can maybe use it in rust-bitcoin 0.15 even
21:57 < andytoshi> this week i am at a blockstream company offsite though and will be offline a lot
21:59 < ariard> is #167 the whole htlc tracking refactoring ? starting to review it now
22:06 < sgeisler> andytoshi: no hurry, I still have to polish the API of lightning-invoice a bit, but I want to publish the first version this month and bitcoin_hashes is one of its dependencies
22:38 < BlueMatt> ariard: yea, its nontrivially-sized in terms of key-logic changes :(
22:39 < BlueMatt> ariard: I still have another stack of patches for channel_reestablish handling built on that one, too :/
23:12 -!- itaseski [~itaseski@213.135.178.20] has quit [Remote host closed the connection]
23:57 < ariard> yeah that's heavy, i'm doing this with BOLT under the eyes, just finish first one on HTLC inbound/outbound
23:57 < ariard> I'm still learning how to be efficient on code review!