--- Day changed Thu Sep 20 2018
01:05 < ariard> Thanks, was easier to build tighter asserts with witness sizes than I believed at first, updated with reviews!
01:06 < ariard> BlueMatt: but is there any reason to get witness size of 138 bytes for accepted htlc script instead of the 139 in BOLT 3 ?
03:33 < BlueMatt> ariard: see pr comment
03:33 < BlueMatt> for the rust-lightning folks, I've been milestone'ing: https://github.com/rust-bitcoin/rust-lightning/milestones?direction=asc&sort=title&state=open
06:52 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 245 seconds]
07:03 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #rust-bitcoin
07:15 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 240 seconds]
07:20 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #rust-bitcoin
07:25 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Ping timeout: 272 seconds]
07:30 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #rust-bitcoin
13:26 -!- nickler [~nickler@185.12.46.130] has quit [Ping timeout: 272 seconds]
13:55 -!- nickler [~nickler@185.12.46.130] has joined #rust-bitcoin
14:21 < andytoshi> dongcarl: i'm not asking you to split up commits in #156. i'm asking you to replace the commits i nitted with ones that have addressed the nit
14:23 < dongcarl> @andytoshi Oh... so more like squashing them?
14:23 < andytoshi> yeah
14:24 < dongcarl> andytoshi: okay cool, that's actually way easier
14:24 < dongcarl> andytoshi: if the nits introduce new things, I don't have to squash tho?
14:25 < andytoshi> dongcarl: right
14:25 < dongcarl> Roger roger
14:25 < andytoshi> in general i'm sorta asking you to create a new history as though the nits were never there
14:26 < andytoshi> vs the strategy where you add commits that fix things, i review those commits specifically, and then we (maybe) squash later
14:26 < dongcarl> Right, that's what I've been doing for the PSBT stuff, so I kinda freaked out when I misunderstood you this morning as separating them would be a GIANT PAIN
14:26 < andytoshi> heh, no, sorry
14:27 < andytoshi> yeah, separating commits is super annoying, but this isn't the kinda change where that'd be helpful
14:27 < dongcarl> If people on here didn't know about fixup commits, they're super great for what andytoshi is describing
14:28 < andytoshi> right, i often create tons of commits marked `f` with one or two changes in them, then reorder/squash them once i'm happy with them
14:29 < dongcarl> yup, I'm trying to transition to that workflow, takes discipline to commit often
14:30 < andytoshi> eventually it takes discipline _not_ to commit :P
14:31 < dongcarl> loll
14:40 < BlueMatt> andytoshi: lol, everyone in bitcoinland stole my fucking f prefix
14:41 < BlueMatt> dongcarl: fwiw, splitting commits doesnt have to be so hard, if you do git reset HEAD^1 then git commit -p you can create new commits relatively easily by selecting hunks
14:41 < dongcarl> BlueMatt: is that just a poor mans's `--fixup`?
14:41 < andytoshi> BlueMatt: i literally did not know it stood for fixup :P
14:42 < BlueMatt> dongcarl: yes, I presume pre---fixup, but didnt realize --fixup (or --autosquash) existed :p
14:42 < andytoshi> i thought it was like "press f to pay respect for this commit that will get squashed"
14:42 < dongcarl> BlueMatt: yeah... I do that at times... but when you're refactoring things can be super convoluted that it takes wayyy too long
14:42 < BlueMatt> lol
14:42 < dongcarl> lol
14:42 < BlueMatt> andytoshi: you know in rebase -i you can write "f" instead of "fixup" so it stands for "put an f next to me in rebase -i" :p
14:45 < andytoshi> lol, that works too
14:56 < andytoshi> updated https://github.com/rust-bitcoin/rust-bitcoin/pull/153 (0-input transactions are always serialized as segwit) but the fix is kinda weird .. we have to count the segwit flag as a non-witness byte for 0-input transactions
14:56 < andytoshi> because it appears even in the "non-witness" serialization
14:59 < andytoshi> hmmmm, this actually disagrees with what core does
15:01 < andytoshi> well, philosophically anyway .. i don't think there's any way to get core to compute the weight of an inputless transaction
15:03 < andytoshi> bitcoin-cli decoderawtransaction 7f0a0180000100011f0120ee0001cbf300e400d271
15:03 < andytoshi> gives a size and vsize of 19 ... while that is actually a 21-byte transaction
15:04 < dongcarl> rust-bitcoin saves the day again
15:05 < andytoshi> heh, well, i believe core's (well, pieter's) position on 0-input transactions is that they don't care about them, they can't show up in valid blocks
15:07 < andytoshi> so basically there are 3 different vsizes that might make sense here ... 19 (no witnesses, so no segwit), 19.5 (no inputs, force segwit, count flag bytes as witness bytes), or 21 (no inputs, force segwit, count flag bytes as non-witness bytes)
15:08 < dongcarl> right, but shouldn't size always be 19?
15:08 < andytoshi> 19 is what core does, but this reflects their willingness to serialize 0-input transactions in a way that won't deserialize
15:08 < andytoshi> 19.5 makes some sort of philosophical sense, in that it's a 19-byte transaction plus two witness bytes
15:09 < andytoshi> and 21 is what you get if you serialize the tx with and "without" segwit and take a weighted average, where "without segwit" still means segwit
16:27 < BlueMatt> ;;seen TamasBlummer
16:27 < gribble> I have not seen TamasBlummer.
16:27 < BlueMatt> :(
16:27  * dongcarl presses f
22:08 -!- ariard [~ariard@167.99.46.220] has joined #rust-bitcoin
22:08 -!- Topic for #rust-bitcoin: Rust-Bitcoin Libraries Discussion. Artisinal Bitcoin for the rest of us. Do NOT have private conversations on the FreeNode network! See https://github.com/rust-bitcoin If you created a repo, and I forgot to make you admin on it (stupid github defaults), ping BlueMatt
22:08 -!- Topic set by BlueMatt [~BlueMatt@unaffiliated/bluematt] [Sun Aug  5 09:06:05 2018]
22:08 [Users #rust-bitcoin]
22:08 [ andytoshi  ] [ cjs77   ] [ mikethetike] [ schmidty     ] [ smoke3   ] 
22:08 [ ariard     ] [ dongcarl] [ neonknight ] [ scoobybejesus] [ treyzania] 
22:08 [ Blackwolfsa] [ gribble ] [ nickler    ] [ sgeisler     ] [ windsok  ] 
22:08 [ BlueMatt   ] [ havik   ] [ savil      ] [ simian_za    ] [ wumpus   ] 
22:08 -!- Irssi: #rust-bitcoin: Total of 20 nicks [0 ops, 0 halfops, 0 voices, 20 normal]
22:08 -!- Channel #rust-bitcoin created Fri Mar  9 17:46:56 2018
22:08 -!- Irssi: Join to #rust-bitcoin was synced in 11 secs