--- Day changed Sat Sep 22 2018
01:14 < ariard> BlueMatt: keeping the code base easy to read on long-term and so bend to a code style policy I'm okay with that
01:15 < ariard> And not something that rustfmt can enforced, but having a consistent policy on whitspaces lines between logical code block could be cool
01:15 < ariard> that something I've messed up more than once I think!
01:16 < dongcarl> If rustfmt is configurable enough, perhaps we only enable the checks that we have consensus on rather than all? Like whitelist instead of blacklist?
01:17 < dongcarl> Apparently they also indicate Stability of config options in the rustfmt GitHub Configurations.md
01:18 < dongcarl> I think an easy config option if they have it is to not to mangle Macros
01:18 < dongcarl> Is to not mangle*
01:19 < ariard> yeah seems better to start with something minimal we all agree on, and add more stuff if we feel it necessary
01:20 < ariard> and avoid spaces, spaces are bad, tab are cool
01:20 < dongcarl> ariard: I tend to agree re spaces but don’t start a war lol
03:16 -!- itaseski [~itaseski@213.135.179.187] has quit [Quit: Leaving]
07:43 < BlueMatt> dongcarl: come to the rust-lightning world, we're all tab refugees :p
07:43 < BlueMatt> or, at least I force everyone to be
07:44 < BlueMatt> ariard: yea, I mean if you want I can more aggressively review for code style, I've just been kinda lazy about it cause I dont want to do a review that is *only* code style and hold up merging something for that
07:48 < dongcarl> Wonder what andytoshi’s opinions are lol... but anyways I do think we should start a minimal rustfmt config, it can do nothing for now, and we can add more to it as we agree on styles
10:03 < dongcarl> I hope we don’t use str::repeat: https://blog.rust-lang.org/2018/09/21/Security-advisory-for-std.html
10:04 < dongcarl> https://groups.google.com/forum/m/#!forum/rustlang-security-announcements might be good to subscribe to
14:38 < andytoshi> dongcarl: we do not. but yeah, i should subscribe to that list (though i think this also hit the main rust blog which i am subscribed to
14:39 < andytoshi> if you're asking my opinion about using rustfmt with a small whitelist i think that's a great idea
14:39 < andytoshi> if you're asking my opinion on spaces vs tabs, i pass :P. but within rust it's basically universal to use four spaces for indentation.
14:41 < dongcarl> Cool, let’s do rustfmt... been on a business trip but should settle down soon to do some real work
14:53 < andytoshi> cool. and i'll try to get through the rust-bitcoin PRs
21:20 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #rust-bitcoin
21:23 < dongcarl> grubles: hi grubles
21:32 < grubles> ohi dongcarl
23:39 < ariard> BlueMatt: well so keep it as it is, we'll refactor later if we think that readability is too bad