--- Day changed Wed Oct 10 2018
00:46 < BlueMatt> ariard: is https://github.com/rust-bitcoin/rust-lightning/pull/198 reviewable right now or should I interpret https://github.com/rust-bitcoin/rust-lightning/pull/198#discussion_r223536049 as you're gonna go change that behavior?
01:22 < BlueMatt> andytoshi: what stuff should I review in bitcoin_hashes?
01:22 < andytoshi> BlueMatt: all the open PRs
01:22 < BlueMatt> heh, k
02:10 < BlueMatt> ariard: yo
07:24 < Blackwolfsa> @BlueMatt on https://github.com/rust-bitcoin/rust-lightning/pull/202 , to try and stop DOS attacks, I added a hashmap to keep track of pubkeys we send sync info to. But is there some other field that is more "set in stone" that we can use to keep track of it. I also think we might want to add timestamps to those entries to expire them.
12:38 < stevenroose> andytoshi: what's the state of the Ledger code in ICBOC? :D I just went through it briefly, but was wondering if it was still working with updated Ledger firmware versions..
12:40 < stevenroose> Also wondering where you got the documentation for that.  I'm considering taking that code to create a minimal general-purpose (:D) library while doing the same for Ledger.
12:48 < stevenroose> Trezor*
14:24 < ariard> BlueMatt: ah sorry didn't check irc last night, 198 is reviewable right now, I think all cases are covered with commit of yesterday, seen you've commented, will be available around 23 utc today
21:31 < andytoshi> stevenroose: it has never worked with the new Ledger firmware ;)
21:31 < andytoshi> but i will fix it, it's pretty minor, i just need to find my notes about how to do it
21:32 < andytoshi> and i learned how to do this by reading the ledger bitcoin app source code, and bugging btchip