--- Day changed Fri Oct 12 2018 08:20 < stevenroose> andytoshi: you mind if I take the code out and work on it a bit? You spoke of notes that would give insight in how to make it compatible with current firmware, I'd be very interesting in those notes as otherwise I'd probably be comparing the Rust impl with another impl.. 08:33 < stevenroose> I would also like to use whatever PSBT support they already have as soon as possible. dongcarl any idea of PSBT support adoption by Trezor and Ledger? 08:38 < stevenroose> andytoshi: you know what? Trezor uses ProtoBuf <3 :D 12:27 < andytoshi> stevenroose: sure, you can look at improving firmware support 12:27 < andytoshi> i don't have any notes, it was a pm from lawrence like six mnoths ago 12:27 < andytoshi> which i've lost 21:17 < stevenroose> if you have an empty struct implementing a trait just to have the implementation of the trait, will the creation of the empty struct be an allocation? 21:18 < stevenroose> Is it better to create a pub const PROTOCOL1: Protocol1 = Protocol1{}; to use globally? Or does an empty struct not allocate (like in Go)? 21:29 < andytoshi> values never allocate 21:30 < andytoshi> and empty structs have zero size 21:30 < andytoshi> so they don't even take up stack space