--- Day changed Fri Oct 19 2018
03:01 < ariard> Hmmm so we can't SecretKey::from_slice() from a zeroed SecretKey right ? would like to serialize some in ChannelMonitor which can happen to be None
12:23 < andytoshi> then you've gotta make a newtype
12:24 < andytoshi> upstream will abort the process if you try to use a zero secret key
14:47 < stevenroose> damn, I didn't know about the bitcoin main crate exporting all the types. Was always using the specific submodule :|
15:15 < andytoshi> it's fairly new
15:17 < andytoshi> and you still have to use the submodules to get the sha2 types. in 0.15/0.16 i will reexport these from `bitcoin_hashes`
15:17 < andytoshi> i guess 0.15. (annoying, we're overlapping version numbers with recent Core versions, so i expect we'll have a few months of confusion...hopefully we can hit 1.0 soon :))
15:19 < andytoshi> then 0.16 will use the new libsecp. (One hard lesson I learned with the 0.13 → 0.14 upgrade for Liquid was that we should *not* update our own API in the same major version as we increase libsecp or serde, because it forces our downstream users to update all 3 crates at once)
15:20 < andytoshi> ..unless they are willing to work around it, like i did, by forking rust-bitcoin, creating a couple "shim" branches that separate these changes out, and then having several commits in a row with `bitcoin = { git = "..." }` dependencies until they've upgraded enough to use the released version again