--- Day changed Fri Nov 09 2018
12:10 < stevenroose> fwiw, I think it's fine to have different repo names than crate names. I like the rust- prefix in repo names so that they make sense without the rust-bitcoin prefix, f.e. when cloning or when forking.
12:10 < stevenroose> I don't have strong feelings about what the Cargo name should be though. It seems to often be somewhere in the middle. IMO, should probably be equal to the crate name (i.e. with underscores)
12:51 < stevenroose> It would be really nice if serde_json would automatically detect FromStr implementations and uses that as a default Deserialize implementation.
12:51 < stevenroose> Go does that, f.e.
12:52 < stevenroose> The Deserialize code that just uses the FromStr code is longer than the FromStr code itself: https://github.com/stevenroose/rust-bitcoindrpc/commit/a628540425478c6e1f64d0ff2b86f0c08bddd5c9#diff-7a2c5806ee0ca595edebdfbe2c71af7aR440
12:55 < stevenroose> dpc: should I rename the github repo? Perhaps just wait until it gets into the rust-bitcoin org. andytoshi, how likely is that to happen? :D
12:55 < stevenroose> Once the json-rpc-without-client PR is merged, the rust-bitcoincore-rpc crate also doesn't use any HTTP client code.
12:55 < stevenroose> Pretty happy with that tbh.
13:38 < stevenroose> dpc: I left some comments on your commits, could you address them, or do you want me to?
13:38 < stevenroose> Perhaps since we settled on most things, we can start making PRs?
15:54 <+andytoshi> stevenroose: next week i'll have time to evaluate the rust-bitcoinrpc situation and also look at your rust-jsonrpc "separate hyper from the rest of the code" crate. can you give me a tl;dr of the different crates that are in play now?
15:55 <+andytoshi> i think these can all come into rust-bitcoin but i need to understand what the overall plan is, and also try using them with the blockstream functionary code to see whether the API makes sense and is compatible with existing use of rust-jsonrpc
16:28 < stevenroose> andytoshi: integrating in functionary I can start doing once the API settles down
16:28 <+andytoshi> there's no rush on that, i'd like to update to rust-bitcoin 0.15 first and get a few more refactors in .. i just want to make sure it's -possible-
16:30 < stevenroose> got distracted, so situation:
16:32 < stevenroose> jsonrpc defines a trait HttpRoundTripper that turns an http::Request in an http::Response basically and it build on that trait.  then I created rust-jsonrpc-hyper that implements that trait for both hyper 0.10 and hyper latest and that also has a utility method to construct a jsonrpc client instance with its own client
16:32 < stevenroose> Then bitcoincore-rpc got refactored with dpc's help, settling down on the API
16:33 < stevenroose> one thing that needs important to note is that it's relying on many of rust-bitcoin's serde implemenations, so I guess it makes sense to have it in the umbrella so that breaking changes can be coordinated
16:33 < stevenroose> it has jsonrpc as a dep, so doesn't force usage of an http client
16:33 < stevenroose> so basically jsonrpc and bitcoincore-rpc both don't have http deps
16:40 <+andytoshi> that sounds greath
16:42 < stevenroose> dpc: I made a number of improvements, and I think we can almost put out a 0.1.0 release of some kind.  I'll wait for your confirmation before going ahead with that :)
16:50 -!- Topic for #rust-bitcoin: Rust-Bitcoin Libraries Discussion. Artisinal Bitcoin for the rest of us. Do NOT have private conversations on the FreeNode network! See https://github.com/rust-bitcoin If you created a repo, and I forgot to make you admin on it (stupid github defaults), ping BlueMatt
16:50 -!- Topic set by BlueMatt [~BlueMatt@unaffiliated/bluematt] [Sun Aug  5 09:06:05 2018]
16:50 [Users #rust-bitcoin]
16:50 [+andytoshi  ] [ dpc             ] [ grubles      ] [ molz         ] [ sgeisler    ] [ windsok] 
16:50 [ ariard     ] [ e4xit           ] [ harding      ] [ neonknight   ] [ simian_za   ] [ wraithm] 
16:50 [ Blackwolfsa] [ elichai2        ] [ havik        ] [ nickler      ] [ stevenroose ] [ wumpus ] 
16:50 [ BlueMatt   ] [ esotericnonsense] [ jamesob      ] [ savil        ] [ TamasBlummer] 
16:50 [ cjs77      ] [ gmaxwell        ] [ midnightmagic] [ scoobybejesus] [ treyzania   ] 
16:50 [ dongcarl   ] [ gribble         ] [ mikethetike  ] [ sdaftuar     ] [ warren      ] 
16:50 -!- Irssi: #rust-bitcoin: Total of 33 nicks [0 ops, 0 halfops, 1 voices, 32 normal]
16:50 -!- Channel #rust-bitcoin created Fri Mar  9 17:46:56 2018
16:50 -!- Irssi: Join to #rust-bitcoin was synced in 19 secs
16:57 < stevenroose> Anyone any idea since what version the [patch.crate-io] thing was introduced? Since we use a local subcrate, rust 1.14.0 fails to build because the cargo at that version doesn't understand that syntax yet.
17:02 < stevenroose> nvm, 1.21.0 it is
17:31 < dpc> stevenroose: I would be happy to talk about "unified lib for is a "bitcoin explorers"" - isn't that what basically "Bitcoin indexer" is? Or you just want to make a trait that bitcoin indexers could implement that would allow running frontend on top of any indexer backend?
17:34 < stevenroose> dpc: "bitcoin indexer" you mean you mean the crate you linked recently? or the general concept?
17:34 < stevenroose> I meant just an interface and then an implementation thereof backed by blockstream.info, blocktrail.com, btc.com, ......
17:35 < stevenroose> But it seems that just an Electrum API client would work.  Blockstream.info's API will probably be that one and instead of a custom indexer, you could just run electrs
17:36 < dpc> stevenroose: My matrix UI just carried me away into too distant past posts. Yeah. I would be interested in looking, talking and hopefuly helping with it, if it's a public crate.
17:37 < dpc> I think waiting for a repo under `rust-bitcoin` org is fine, and than it can be named the same as the crate is, since `rust-` prefix is already in the org name.
17:37 < dpc> You can toggle making master protected, so everything has to go through PRs now, fine with me.
17:37 < dpc> Yesterday I just made sure no API that was in `rust-bitcoin-rpc` was left unported.
17:42 < stevenroose> > I like the rust- prefix in repo names so that they make sense without the rust-bitcoin prefix, f.e. when cloning or when forking.
17:42 < stevenroose> Hmm :/
17:42 < stevenroose> Currently bitcion_hashes is the only repo that breaks the convention of `rust(-[a-z]+)+` repo names..
17:49 < dpc> Oh well. I don't think git repo name matters too much anyway.
17:52 < stevenroose> well, I have a stevenroose/dart-bitcoin and stevenroose/rust-bitcoin that would collide f.e.
17:52 < stevenroose> and just stevenroose/bitcoin from bitcoin/bitcoin ofc
21:06 < stevenroose> BlueMatt, ariard: what kind of sub-satoshi value do you see useful in the future of lightning?
21:06 < stevenroose> I think msat is default in Lightning things now, no? Does it go further?
22:22 < stevenroose> ugh, I just stumbled upon overflow arithmetic in Rust
22:23 < stevenroose> apparently in test mode, you can't just multiply a variable
22:23 < stevenroose> And checked_pow and checked_div are nightly :|
22:47 < dpc> stevenroose: https://doc.rust-lang.org/std/primitive.i64.html#method.wrapping_mul ?
22:52 < dpc> Rust has a checked math by default in test, and it's disabled in release (but it can be enabled). http://huonw.github.io/blog/2016/04/myths-and-legends-about-integer-overflow-in-rust/
22:52 < dpc> But "wrapping" versions are all stable, IIRC.
22:53 < stevenroose> not pow
22:53 < stevenroose> but I got it fixed, just normal pow that panics
22:54 < stevenroose> sgeisler: I'm giving a full rewrite of Amount a shot with your suggestion, having fun so far :)
23:14 < sgeisler> stevenroose: nice :) I'd really like to see the result of that
23:16 < sgeisler> if you need checked_pow you can find it in num-traits https://docs.rs/num-traits/0.2.6/num_traits/pow/fn.checked_pow.html
23:21 < dpc> stevenroose: I thought you wanted it not to panic. I was wondering if `u128` is of any help.
23:29 < ariard> stevenroose: personally can't say, maybe have a look on LN summit notes : https://docs.google.com/document/d/1ZgAfJsMsvrhCoc_masdmuH4gJ1R03_6EYF4UmsHxny4/edit#heading=h.15d1s8hvo919
23:50 < stevenroose> sgeisler: that's nightly, would rather be stable fow now
23:50 < stevenroose> sgeisler: it's getting real curious will upload soon :)