--- Log opened Tue Nov 20 00:00:26 2018
01:28 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds]
01:41 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
07:33 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
09:51 -!- TamasBlummer1 [~Thunderbi@p200300DD672B96221192158B90D89D36.dip0.t-ipconnect.de] has joined #rust-bitcoin
09:52 -!- TamasBlummer [~Thunderbi@p200300DD672B963359390C5ABEF72D87.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
09:52 -!- TamasBlummer1 is now known as TamasBlummer
11:44 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
11:46 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #rust-bitcoin
11:46 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host]
11:46 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
12:49 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
12:53 < BlueMatt> ariard: nice job on the tests for #230! I didn't review them all in fine detail but looked through them a bunch and checked that all the new code got well-tested by them!
12:55 < dongcarl> Looks like the fuzzing on https://travis-ci.org/rust-bitcoin/rust-bitcoin/jobs/455816975 failed, seems to be unrelated to my change, but is something to do with `Decimal`
12:59 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #rust-bitcoin
12:59 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host]
12:59 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
13:02 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
13:03 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
13:08 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 240 seconds]
13:16 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
13:45 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-hiwpopjytsxphpxf] has quit [Quit: Connection closed for inactivity]
14:04 -!- treyzania [~treyzania@paphos.tr3y.io] has left #rust-bitcoin ["Leaving"]
15:07 -!- jamesob [sid180710@gateway/web/irccloud.com/x-qjlzinpimeghohsc] has quit [Ping timeout: 264 seconds]
15:07 -!- jamesob [sid180710@gateway/web/irccloud.com/x-xeasitrurvyjvgxa] has joined #rust-bitcoin
16:12 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
16:43 < ariard> BlueMatt: thanks, just added a last one test that I forgot, really simple this one
17:17 -!- _cryptodesktop_i [~John@91.245.76.90] has joined #rust-bitcoin
17:51 -!- _cryptodesktop_i [~John@91.245.76.90] has quit [Ping timeout: 252 seconds]
18:57 < BlueMatt> ariard: heh, sorry, #198 needs rebase
18:57 < BlueMatt> though it was your pr that conflicted :p
19:13 < ariard> guess what I'm doing right now
19:14 < ariard> yes I know that my PRs both conflicts :p
19:14 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
19:25 < BlueMatt> ariard: hmm, i think we're still talking past each other on #207
19:26 < BlueMatt> my anticipation here is that we would have the handle_channel_update call in ChannelManager return Result<(), HandleError>
19:26 < BlueMatt> and then the Channel objects would store information about the feerate of the other side
19:27 < BlueMatt> for public channels the Router will always know the latest, and thats great, but for private channels the Router will throw away any messages it gets, and thats fine, cause it wasnt gonna know about those channels anyway
19:27 < BlueMatt> instead, we use the first_hops argument to Router::get_route()
19:28 < BlueMatt> so the additional information that is stored in the Channel objects to track the current feerate information we include in channelmanager::ChannelDetails
19:28 < BlueMatt> and then the user calls ChannelManager::list_usable_channels() which gets the latest feerate information for local-only channels out of the Channel objects, provides them in ChannelDetails structs, and then those get passed in to get_route
19:28 < BlueMatt> then we dont have to have any special-casing of local channels in Router
19:29 < BlueMatt> which just feels icky
19:29 < BlueMatt> anyway, I'm gonna head to bed, sorry, I meant to get a review of 198 done today but it got away from me :(
19:29 < BlueMatt> anyway, I promise I'll do that tomorrow
19:38 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
19:53 < ariard> BlueMatt: lol, was good to add test, it was broken, because I reversed payment_hash and payment_preimage somewhere
19:53 < ariard> so it should be reviewable now, but will amend with few nits tomorrow
19:54 < ariard> would you be okay to typify payment_hash, payment_preimage to avoid same API misusages in the future? I wouldn't be the last to hit himself with it if not
19:55 < ariard> will be back on #207 tomorrow
--- Log closed Wed Nov 21 00:00:27 2018