--- Log opened Fri Nov 30 00:00:38 2018
00:56 -!- tdc [~tdc@95.47.32.237] has left #rust-bitcoin ["Leaving"]
02:36 < stevenroose> dongcarl: why does psbt::Deserialize return a consensus::encode::Error?
02:37 < stevenroose> I'm trying to add a UTF-8 encoded psbt field, which now seemingly requires me to add a Utf8 variant to the consensus encode error..
02:43 < stevenroose> andytoshi: is this a fair addition to the consensus encode error variant, even though utf8 is not part of consensus afaik:     Utf8(std::string::FromUtf8Error),
02:50 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
02:50 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
02:50 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
03:15 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
03:15 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
03:15 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
03:15 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
03:30 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
03:34 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
03:35 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
03:35 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
04:22 < stevenroose> dongcarl: you merging those two tiny changes to your PSBT branch would simplify my dependency mess a tiny bit :)
04:45 < stevenroose> meh pushed all repos to a devel branch and depend on those :D
04:45 < stevenroose> because [patch] sections don't seem to work recursively :/
04:45 < stevenroose> even though I swear they did 2 months ago
08:03 -!- TamasBlummer1 [~Thunderbi@p200300DD67286B71C09D22D3048757B8.dip0.t-ipconnect.de] has joined #rust-bitcoin
08:05 -!- TamasBlummer [~Thunderbi@p200300DD67286B09C09D22D3048757B8.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
08:05 -!- TamasBlummer1 is now known as TamasBlummer
08:25 < ariard> BlueMatt: took me longer than expected but #198 should be better thanks to your input
08:25 < ariard> BlueMatt: see https://github.com/rust-bitcoin/rust-lightning/pull/198#issuecomment-443257413
08:46 -!- Tralfaz [~none@104.248.145.220] has joined #rust-bitcoin
08:48 < andytoshi> stevenroose: where is string encoding used anywhere?
08:48 < andytoshi> oh i see, you want a utf8 psbt field
08:48 < andytoshi> what field?
09:08 -!- Tralfaz [~none@104.248.145.220] has quit [Remote host closed the connection]
09:16 -!- Tralfaz [~none@104.248.145.220] has joined #rust-bitcoin
09:35 < BlueMatt> ariard: cool, will take a look in a bit!
10:13 -!- Tralfaz [~none@104.248.145.220] has quit [Ping timeout: 246 seconds]
10:28 < dongcarl> stevenroose: ah I forgot those branches
10:28 < dongcarl> I’ll review before end of week
10:47 -!- Tralfaz [~none@104.248.145.220] has joined #rust-bitcoin
11:21 -!- Tralfaz [~none@104.248.145.220] has quit [Read error: Connection reset by peer]
11:22 -!- Tralfaz [~none@104.248.145.220] has joined #rust-bitcoin
11:26 -!- Tralfaz [~none@104.248.145.220] has quit [Remote host closed the connection]
11:30 -!- Tralfaz [~none@104.248.145.220] has joined #rust-bitcoin
11:39 -!- Tralfaz [~none@104.248.145.220] has quit [Ping timeout: 245 seconds]
11:43 -!- Tralfaz [~none@104.248.145.220] has joined #rust-bitcoin
12:00 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: Connection reset by peer]
12:00 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
12:05 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
12:05 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 272 seconds]
12:09 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Ping timeout: 246 seconds]
12:10 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
12:10 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
12:10 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
12:13 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: Connection reset by peer]
12:14 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
12:14 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
12:14 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
12:18 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds]
12:19 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
12:19 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
12:19 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
12:20 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: Connection reset by peer]
12:21 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
12:26 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds]
12:26 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
12:31 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: Connection reset by peer]
12:31 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
12:35 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Client Quit]
14:36 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 246 seconds]
15:05 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Remote host closed the connection]
15:17 < BlueMatt> ariard: nice, I think the high-level api/design is pretty much right modulo the few comments I left
15:18 < BlueMatt> I can probably find time to re-review tomorrow or sunday if you feel like working on it
15:18 < BlueMatt> otherwise no rush
16:52 -!- Tralfaz [~none@104.248.145.220] has quit [Remote host closed the connection]
18:27 -!- _cryptodesktop_i [~John@91.245.77.21] has joined #rust-bitcoin
19:01 -!- _cryptodesktop_i [~John@91.245.77.21] has quit [Ping timeout: 250 seconds]
19:16 < ariard> BlueMatt: updated with some of your comments and working on others, should be quite available this we, would like to get it done as it has been open sometimes ago now :)
--- Log closed Sat Dec 01 00:00:39 2018