--- Log opened Mon Dec 03 00:00:41 2018 01:46 < andytoshi> BlueMatt: can you ack https://github.com/rust-bitcoin/rust-bitcoin/pull/179 ? it adds a fuzztest and does nothing else 02:30 -!- TamasBlummer1 [~Thunderbi@p200300DD673DE942C09D22D3048757B8.dip0.t-ipconnect.de] has joined #rust-bitcoin 02:33 -!- TamasBlummer [~Thunderbi@p200300DD673DE906C09D22D3048757B8.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 02:33 -!- TamasBlummer1 is now known as TamasBlummer 03:42 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has quit [Read error: Connection reset by peer] 03:43 -!- wumpus [~ircclient@pdpc/supporter/professional/wumpus] has joined #rust-bitcoin 03:43 -!- dongcarl [sid321684@gateway/web/irccloud.com/x-gdifntnxjpmpetls] has quit [Ping timeout: 268 seconds] 03:44 -!- dongcarl [sid321684@gateway/web/irccloud.com/x-bjywumazibhiditc] has joined #rust-bitcoin 03:48 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-vkxtdljadncilojp] has joined #rust-bitcoin 06:48 < andytoshi> in https://github.com/rust-bitcoin/rust-bitcoin/pull/195 i propose to upgrade rust-secp to 0.12 in a new version of rust-bitcoin 06:49 < andytoshi> which has no breaking changes except to update the rust-secp dependency. thoughts? 06:51 < andytoshi> oh, actually there are a couple other breaking things i want to do to rust-secp before i do this 06:52 -!- real_or_random [~real_or_r@vmd27468.contaboserver.net] has joined #rust-bitcoin 07:08 -!- real_or_random [~real_or_r@vmd27468.contaboserver.net] has quit [Quit: ZNC 1.7.1 - https://znc.in] 07:15 -!- real_or_random [~real_or_r@173.249.7.254] has joined #rust-bitcoin 07:17 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 07:55 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 250 seconds] 07:57 -!- warren [~warren@fedora/wombat/warren] has joined #rust-bitcoin 08:54 -!- grubles [~grubles@unaffiliated/grubles] has joined #rust-bitcoin 09:28 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-vkxtdljadncilojp] has quit [Quit: Connection closed for inactivity] 10:13 < BlueMatt> ariard: cool, will hold off 10:13 < BlueMatt> ariard: I presume we may need it in the future, though? 10:13 < BlueMatt> just not for 198? 10:15 < BlueMatt> andytoshi: looks fine, one comment, but I'll ack it if you dont feel like bothering to fix it 10:16 < andytoshi> BlueMatt: i don't feel like it :P 10:16 < andytoshi> or rather, it's 7PM here, i'm happy to do it tomorrow morning 10:17 < BlueMatt> nah, doesnt matter lol 10:17 < BlueMatt> done 10:18 < andytoshi> thanks! 14:41 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:33 < sgeisler> I just spent half an hour figuring out why Sha256d was suddenly broken in my base58 encoding tests :/ turns out intellij activates all features by default when running tests and this made the fuzztest feature replace the sha2 module with a mocked version deceptively named util::sha2. I really dislike having a completely broken Sha256 implementation laying around in util. 15:47 < gwillen> eek, that is a weird interaction. 15:59 -!- nothingmuch [~user@213.152.161.30] has quit [Ping timeout: 250 seconds] 16:06 -!- _cryptodesktop_i [~John@91.245.78.70] has joined #rust-bitcoin 16:10 -!- nothingmuch [~user@213.152.161.74] has joined #rust-bitcoin 16:24 -!- nothingmuch [~user@213.152.161.74] has quit [Ping timeout: 240 seconds] 16:40 -!- _cryptodesktop_i [~John@91.245.78.70] has quit [Ping timeout: 250 seconds] 19:21 < ariard> BlueMatt: #198 updated with test_onchain_to_onchain claim completed, it does what we want, passing on-chain state to backward monitor and claiming it in case of broadcast of remote commitment tx 19:23 < ariard> BlueMatt: I think #198 is done, just maybe need to agree on https://github.com/rust-bitcoin/rust-lightning/pull/198#discussion_r238128465 19:23 < ariard> obviously need more tests 19:24 < ariard> BlueMatt: pr'ed a refactored version of #264, for now seems to me we don't need short_channel_id as linkage is done by ChannelManager with HTLCSource.short_channel_id 22:45 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds] 22:53 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #rust-bitcoin --- Log closed Tue Dec 04 00:00:42 2018