--- Log opened Wed Dec 12 00:00:06 2018
--- Day changed Wed Dec 12 2018
00:00 -!- grubles [~grubles@unaffiliated/grubles] has joined #rust-bitcoin
02:20 -!- TamasBlummer1 [~Thunderbi@p200300DD673DE9374D298C6456869AB8.dip0.t-ipconnect.de] has joined #rust-bitcoin
02:22 -!- TamasBlummer [~Thunderbi@p200300DD673DE976E8944D7352F9F733.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
02:22 -!- TamasBlummer1 is now known as TamasBlummer
06:03 < andytoshi> dongcarl: go for it, i was planning to do it today but i can hold off
07:53 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
08:30 -!- Tralfaz [~none@c-73-221-225-225.hsd1.wa.comcast.net] has joined #rust-bitcoin
08:31 -!- Tralfaz [~none@c-73-221-225-225.hsd1.wa.comcast.net] has quit [Max SendQ exceeded]
08:33 -!- Tralfaz [~none@c-73-221-225-225.hsd1.wa.comcast.net] has joined #rust-bitcoin
08:33 -!- Tralfaz [~none@c-73-221-225-225.hsd1.wa.comcast.net] has quit [Remote host closed the connection]
08:36 -!- Tralfaz [~none@104.248.145.220] has joined #rust-bitcoin
09:07 -!- Tralfaz [~none@104.248.145.220] has quit [Read error: Connection reset by peer]
09:07 -!- Tralfaz [~none@104.248.145.220] has joined #rust-bitcoin
09:19 -!- Tralfaz [~none@104.248.145.220] has quit [Quit: Leaving]
09:20 -!- Tralfaz [~none@104.248.145.220] has joined #rust-bitcoin
10:50 -!- nothingmuch [~user@62.102.148.162] has joined #rust-bitcoin
14:23 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
14:23 -!- scoobybejesus_ [sid271506@gateway/web/irccloud.com/x-fhjnkmvtdfqhkcrh] has joined #rust-bitcoin
14:23 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
14:29 -!- scoobybejesus [sid271506@gateway/web/irccloud.com/x-kqgucfqxcniqosxo] has quit [Ping timeout: 250 seconds]
14:29 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 250 seconds]
14:29 -!- scoobybejesus_ is now known as scoobybejesus
14:31 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
14:34 < dongcarl> andytoshi: while doing the PR, I realized that we need a few changes to bitcoin_hashes first before it can be integrated (a few `derive`s and fuzzing in particular)
14:35 < dongcarl> I'll open a PR against bitcoin_hashes with those changes and hopefully we can do minor release
14:35 < andytoshi> ok, cool
15:01 < BlueMatt> ariard: cool
15:01 < BlueMatt> ariard: I'm currently rewriting a bunch of 269 (and related stuff) because I (and you, though I started it :p) made the faulty assumption that all htlcs which we need to fail backwards are in the commitment transaction
15:02 < BlueMatt> ariard: that isnt true, so instead of Vec<(HTLCInCommitment, Option<HTLCSource>)> we need two vecs :/
15:02 < BlueMatt> cause we need to fail backwards htlcs which were below our dust threshold and thus not included but which timed out
15:02 < BlueMatt> I'm probably not gonna implement all the cases for 269, just do the refactor and then actually handle the shit in a future pr :/
15:16 -!- Tralfaz [~none@104.248.145.220] has quit [Ping timeout: 250 seconds]
15:51 < dongcarl> sgeisler andytoshi: I've found that there are quite a few `derive`s that seem unnecessary for our `rust-bitcoin` data structures, and when those structures contain hashes, the trait requirement propagates down to `bitcoin_hashes` as well. For example, it makes no sense for `Payload` and `Address` to implement `PartialOrd` or `Ord`
15:52 < dongcarl> I believe we should remove them
15:52 < sgeisler> dongcarl: It can make sense if you ever want to use these structs as key for a BTreeMap
15:53 < sgeisler> I don't say that is the case, but we should be careful
15:53 < dongcarl> I guess you're right...
15:53 < dongcarl> Is that used right now?
15:54 < sgeisler> I don't know, but it's not a big problem to derive these traits for the Hashes
15:55 < dongcarl> Yeah no big deal, a little bit of a hassle for 512 bit ones tho
15:55 < sgeisler> what's the problem with the 512 bit ones?
15:55 < sgeisler> ah, you can't derive ...
15:55 < sgeisler> you have to impl yourself I guess?
16:03 < ariard> BlueMatt: ah was answering on your last volley of comments
16:03 < ariard> shit and none of us thought about it until now :(
16:04 < ariard> will fix 207, but stay available when it's ready to review
16:09 < BlueMatt> ariard: yea, oh well, at least we know about it now and can plumb it through
16:41 -!- _cryptodesktop_i [~John@91.245.74.33] has joined #rust-bitcoin
17:15 -!- _cryptodesktop_i [~John@91.245.74.33] has quit [Ping timeout: 250 seconds]
18:48 < BlueMatt> ariard: ok pushed update for https://github.com/rust-bitcoin/rust-lightning/pull/269
19:21 < ariard> BlueMatt: will review tomorrow, made progress on whole ChannelMonitor review : https://github.com/rust-bitcoin/rust-lightning/issues/137#issuecomment-446828939
21:03 < BlueMatt> dongcarl: whats the status of bitcoin_hashes in rust-bitcoin? looks like wasm doesn't want to build rust-lightning/bitcoin right now due to rustc-serialize :/
21:14 < dongcarl> BlueMatt: I made it work today... need to add fuzzing stubs to bitcoin_hashes, then I’ll do a minor release for bitcoin_hashes
21:14 < dongcarl> Makes the whole codebase much cleaner IMO
21:15 < dongcarl> rustc-serialize... is a dependency of rust crypto?
21:55 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 260 seconds]
22:12 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #rust-bitcoin
23:28 < dpc> I think `rust-bitcoin` would be a perfect project to formally keep track of code reviews of dependencies it uses. https://users.rust-lang.org/t/alpha-testers-needed-for-cargo-crev-crate-review-system-for-rust/23210 - I could use some feedback.
23:47 < dongcarl> dpc: amazing work, sgeisler was telling me that we needed a tool like this
23:49 < dongcarl> do we need a separate repository for the reviews?
23:50 < dpc> I haven't thought about it, but not really, I guess.
23:52 < dpc> Though for project it might be better to just keep trust proofs for trusted members in the project itself and let them push their own projects.
23:54 < dpc> The whole workflow, especially for organizations is still a subject for discussion. I am looking forward for some feedback from interested groups.
--- Log closed Thu Dec 13 00:00:50 2018