--- Log opened Thu Jan 03 00:00:10 2019 00:51 -!- e4xit_ [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin 00:53 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 246 seconds] 02:09 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-hlisypdqfbhdfihr] has joined #rust-bitcoin 02:09 -!- e4xit_ [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has left #rust-bitcoin ["WeeChat 1.9.1"] 02:10 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin 02:40 -!- TamasBlummer1 [~Thunderbi@p200300DD67243B07CC57C785112B8FDA.dip0.t-ipconnect.de] has joined #rust-bitcoin 02:42 -!- TamasBlummer [~Thunderbi@p200300DD67243B81CC57C785112B8FDA.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 02:42 -!- TamasBlummer1 is now known as TamasBlummer 02:43 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: quit] 02:46 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin 06:53 -!- nothingmuch [~user@62.102.148.164] has joined #rust-bitcoin 07:17 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 12:00 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 12:00 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-hlisypdqfbhdfihr] has quit [Quit: Connection closed for inactivity] 12:14 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 13:11 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 13:13 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 20:00 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 245 seconds] 20:00 -!- grubles_ [~grubles@unaffiliated/grubles] has joined #rust-bitcoin 20:17 -!- grubles_ is now known as grubles 21:26 -!- grubles_ [~grubles@unaffiliated/grubles] has joined #rust-bitcoin 21:28 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 250 seconds] 21:42 -!- grubles [~grubles@unaffiliated/grubles] has joined #rust-bitcoin 21:44 -!- grubles_ [~grubles@unaffiliated/grubles] has quit [Ping timeout: 240 seconds] 23:44 < sgeisler> I just set up crev and will try to add reviews for all the rust-bitcoin projects I know/have worked on. I'd like to encourage you to do the same :) even though the explicit git checkin is a bit tedious it's a great software and a step in the right direction to ensure code review. 23:45 < sgeisler> https://github.com/dpc/crev 23:46 < sgeisler> thanks dpc for tackling this issue :) 23:54 < dpc> :) 23:54 < dpc> sgeisler: Can you elaborate on "explicit git checkin is a bit tedious"? 23:54 < dpc> I'm not sure what you mean exactly. 23:55 < sgeisler> I have to mentally keep track of actually publishing my reviews. 23:56 < sgeisler> I guess that's a trade off regarding explicitness, but I'd like it if review would mean: sign review+commit+push 23:56 < dpc> We could have a command for that. :) 23:56 < dpc> You could have a shell alias too, I belive. 23:56 < dpc> BTW. I've added you to https://github.com/dpc/crev/wiki/List-of-Proof-Repositories. Hope you don't mind. 23:57 < dpc> There's `cargo crev publish` which does `commit + push` already. 23:57 < sgeisler> nice :D 23:57 < sgeisler> oh, did'n notice that, thx, what does it use as commit msg? 23:57 < dpc> I should add `-m` support to both `commit` and `publish`. Though you can run any git command with `cargo crev git` 23:57 < dpc> It will ask, right now. 23:58 < dpc> But `cargo crev git` can do anything that `git` can. 23:58 < dpc> As it just calls the `git` in the right dir. 23:59 < sgeisler> Ah, yeah, imo the best UX would be to just set the commit message to "add review for {crate} v{version}" in a review+commit+push command --- Log closed Fri Jan 04 00:00:11 2019