--- Log opened Tue Jan 15 00:00:21 2019
00:08 -!- cjs77 is now known as tarib0t
00:11 -!- tarib0t is now known as cjs77
01:13 -!- TamasBlummer [~Thunderbi@p200300DD67243B19F53D22B0781D4219.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
06:55 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-cgsbhmamijpannnb] has joined #rust-bitcoin
07:32 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
08:07 < BlueMatt> dongcarl: I mean I *also* prefer a 1.5-2 year+ old compiler target
08:07 < BlueMatt> though if we cant get that thats kinda ok given rust is so new :/
08:07 < BlueMatt> andytoshi: where are we with bitcoin_hashes?
08:08 < BlueMatt> andytoshi: I want to do a rust-lightning bump but we now depend on git bitcoin_hashes :/
08:22 < andytoshi> dongcarl: i'm begrudgingly ok with 1.22. though this situation bugs me in general because i don't know what our policy should be for "bug in old compiler forces us to increase the minimum version"
08:23 < andytoshi> BlueMatt: lemme check, iirc it's ready to go and we just need a rust-bitcoin bump to use it (and decide to what extent we replace the rust-bitcoin native types with it)
08:23 < BlueMatt> andytoshi: I was under the impression we were blocked on the secp integration
08:23 < BlueMatt> ie ThirtyTwoByteHash trait
08:24 < andytoshi> hmm, yeah, it would be good to resolve that first, though it's not essential
08:24 < andytoshi> it may make sense to just release without it so we can get a feel for what the ergonomics are
08:24 < andytoshi> and let that guide the design of the trait
08:24 < BlueMatt> ugh, I guess 1.22 is 1 year + a few months. I'm ok with with it, but would prefer a two year policy thereafter or so
08:24 < BlueMatt> andytoshi: hmm, I guess I'm ok with that too
08:25 < BlueMatt> would be nice to get a bump with the new secp ergonomics either way
08:26 < andytoshi> kk. let me take a look at the state of the lib now. are there unpublished breaking changes in git master?
08:26 < andytoshi> of rust-bicoin
08:26 < andytoshi> bitcoin
08:26 < dongcarl> Okay so I've got branches for both bumping secp to 0.12
08:26 < dongcarl> and for integrating bitcoin_hashes
08:27 < dongcarl> I want to talk about integrating bitcoin_hashes
08:27 < andytoshi> dongcarl: oh awesome
08:27 < andytoshi> can we merge the secp one without further discussion (pending review ofc)
08:28 < BlueMatt> I think so, yea
08:28 < andytoshi> it looks like the only breaking changes are to the opcodes module (and i'm unsure if they're even breaking changes) ... so if we bring in the new rust-secp we can release 0.16 with just those two things
08:28 < dongcarl> Sure, I'll just clean it up a bit
08:28 < andytoshi> then 0.17 with bitcoin_hashes
08:29 < andytoshi> then the other in-flight things will go into 0.18
08:29 < BlueMatt> I think secp can take a minor version bump, too
08:29 < andytoshi> you mean i should publish a new minor version of rust-secp?
08:29 < BlueMatt> only changes are fixing cc, removing libc dep, and fixing fuzztarget (which I want on crates)
08:29 < BlueMatt> yes
08:29 < andytoshi> ok awesome, i'll pr to do that right now
08:30 < andytoshi> and thanks to you and tim and carl for pushing that stuff through in my absense!
08:30 < dongcarl> :-)
08:31 < BlueMatt> andytoshi: I'm gonna take https://github.com/rust-bitcoin/rust-bitcoin/pull/208 unless you have objections to removing the (exposed) util::iter::Pair utility thinggy
08:31 < BlueMatt> that would be a (essentially) breaking change
08:32 < dongcarl> Actually I see that my current bitcoin_hashes integration is no worse in performance than the existing code
08:32 < dongcarl> So I'll PR that as well
08:32 < dongcarl> We can talk about optimization later
08:33 < andytoshi> BlueMatt: ack. i'm ok with breaking that alongside increasing the secp version
08:33 < BlueMatt> oooook
08:34 < andytoshi> i generally want to minimize breakage alongside secp version bump, but for stuff like this i expect in practice it is not breaking anything at all
08:34 < BlueMatt> yea, I'd be surprised if anyone were using that
08:34 < andytoshi> rust-secp version bump https://github.com/rust-bitcoin/rust-secp256k1/pull/93
08:47 < BlueMatt> sgeisler: happy to take https://github.com/rust-bitcoin/rust-bitcoin/pull/208 but I think want to drop the move there. its kinda nonsense given that function is called many times, though its ignored given nothing is moved into it right now
09:10 < BlueMatt> andytoshi: looks like you can merge https://github.com/rust-bitcoin/rust-secp256k1/pull/93
09:27 < andytoshi> nice done
09:29 < andytoshi> published
09:52 < dongcarl> sgeisler: https://github.com/rust-bitcoin/rust-bitcoin/pull/211#pullrequestreview-192772149
09:52 < dongcarl> Why would bumping rust version help?
11:00 < dongcarl> secp bump ready for merging: https://github.com/rust-bitcoin/rust-bitcoin/pull/213
11:01 < andytoshi> dope thanx
11:02 < dongcarl> loc
11:03 < andytoshi> merged
11:03 < andytoshi> i'll PR to update the library version
11:05 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/214
11:06 < BlueMatt> ninja'd 208 in :p
11:06 < BlueMatt> oops, needs CHANGELOG update for that
11:06 < BlueMatt> noting the Iter Pair removal
11:07 < andytoshi> oh right!
11:07 < andytoshi> i did notice it but forgot that it was more than just an optimitaziton
11:08 < andytoshi> updated pr
11:16 < dongcarl> andy
11:16 < dongcarl> andytoshi BlueMatt could we do another release of bitcoin_hashes?
11:17 < dongcarl> I need the fuzzing features
11:17 < andytoshi> sure
11:19 < andytoshi> i guess 0.2.0
11:22 < andytoshi> https://github.com/rust-bitcoin/bitcoin_hashes/pull/23
13:29 < dongcarl> andytoshi: merged, can you publish to crates?
13:53 < andytoshi> sure one sec
13:55 < andytoshi> done
14:07 < dongcarl> Thank you sirt!
14:07 < dongcarl> sir*
15:04 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-cgsbhmamijpannnb] has quit [Quit: Connection closed for inactivity]
15:37 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
23:27 -!- nothingmuch [~user@213.152.161.30] has quit [Ping timeout: 246 seconds]
23:29 -!- nothingmuch [~user@213.152.161.211] has joined #rust-bitcoin
--- Log closed Wed Jan 16 00:00:23 2019