--- Log opened Fri Jan 18 00:00:24 2019
00:22 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
00:26 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds]
01:29 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
02:17 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 252 seconds]
02:18 -!- TamasBlummer1 [~Thunderbi@p200300DD67243B15308E754F02172A2A.dip0.t-ipconnect.de] has joined #rust-bitcoin
02:19 -!- TamasBlummer [~Thunderbi@p200300DD67243B26200CC345B02CE51E.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
02:19 -!- TamasBlummer1 is now known as TamasBlummer
02:20 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
02:25 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
03:22 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
03:35 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds]
04:01 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
04:06 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
04:09 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
04:13 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
04:13 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
06:11 < nothingmuch> dongcarl: fwiw still at it, currently trying to understand serde + strason macros, the error happens sometime before strason calls from_hex during decoding
06:12 < dongcarl> nothingmuch: No worries! Let me know if I can help in any way.
06:13 < nothingmuch> will do if i get stuck, though most of my experience so far is trying to trick the compiler into letting me do stuff i'd be able to get away with in go or a scripting language to try and bisect the call graph
06:13 < nothingmuch> damn rust type system for actually enforcing sanity ;-)
06:15 < nothingmuch> anyway it's a really good learning experience so far, much better than writing toy stuff before, and specifically diving into serde is why i wanted to learn rust in the first place ^_^
06:50 < andytoshi> BlueMatt: sorry, i had no internet connection for most of yesterday
06:50 < andytoshi> oh, and i'm reading scrollback
06:50 < andytoshi> did you get all the secp bumps you need? or i needto publish a new one?
06:50 < andytoshi> dongcarl: isn't bip62 just signature stuff? what do you mean it's implemented in rust-bitcoin?
06:51 < dongcarl> andytoshi: I'm talking about https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#Push_operators
06:52 < dongcarl> I'm refactoring some of that code to take advantage of the nice interaction between Iterator and Result
06:53 < dongcarl> Perhaps the push operators part of BIP62 is just standard? I'm probably missing some context here
06:53 < andytoshi> can you link to code?
06:57 < dongcarl> Yes one sec
06:57 < dongcarl> andytoshi: Here's the BIP62 error: https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/blockdata/script.rs#L156
06:58 < dongcarl> Here's where it's used: https://github.com/rust-bitcoin/rust-bitcoin/blob/master/src/blockdata/script.rs#L447
06:58 < andytoshi> so, (a) the link to bip62 is just documentation, which is why it links to a definition and not anything normative
06:58 < andytoshi> (b) the minimality is clearly optional, you have to set `enforce_minimal` to true to get it
06:58 < andytoshi> (c) it's needed for script serialization to roundtrip
06:58 < andytoshi> (d) it's standard
06:59 < andytoshi> please do not remove this functionality
06:59 < andytoshi> if there's a better doc link to what "minimal push" means we can certainly replace the link
06:59 < andytoshi> and if you want to split out the iterator into minimal/nonminimal variants you're welcome to
06:59 < dongcarl> Ah okay!
06:59 < andytoshi> but we need this for miniscript
07:00 < dongcarl> Yeah no I knew I was missing some context
07:00 < dongcarl> Thanks for explaining
07:00 < andytoshi> yep i gotcha. agree it's confusing to link to a withdrawn bip :)
07:23 < BlueMatt> andytoshi: I merged it, just need a version bump/crates bump
07:34 < andytoshi> oh, just #94?
07:36 < andytoshi> https://github.com/rust-bitcoin/rust-secp256k1/pull/95 is the version bump
07:44 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
08:05 < BlueMatt> andytoshi: yea
08:06 < BlueMatt> andytoshi: also, a note for the Message-from-hash-without-unwra-trait stuff: need to check the error in fuzztarget mode and convert it to some constant value. Currently I convery all-0s-fuzztarget-Messages into all-1s
08:06 < BlueMatt> well, hex-1s
08:06 < BlueMatt> err, 1 bytes, not 1 bits
08:12 < andytoshi> published 0.12.2
08:12 < BlueMatt> kool
08:13 < andytoshi> taking off for a bit, the MIT mystery hunt is starting. should be back online in a couple hours when things get going. available only by signal/sms
08:13 < BlueMatt> nothing blocking me now =D
11:09 < gwillen> andytoshi: happy hunting :D
11:25 < andytoshi> gwillen: you too!
15:10 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
--- Log closed Sat Jan 19 00:00:25 2019