--- Log opened Wed Jan 23 00:00:28 2019 01:41 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-eiscrdihrhnqdjjo] has joined #rust-bitcoin 03:38 -!- nothingmuch [~user@213.152.161.234] has quit [Ping timeout: 245 seconds] 03:50 -!- icota_ [~igor@58-138.dsl.iskon.hr] has quit [Quit: Konversation terminated!] 04:43 -!- TamasBlummer1 [~Thunderbi@p200300DD672D1A28E151A5C27DD8979D.dip0.t-ipconnect.de] has joined #rust-bitcoin 04:45 -!- TamasBlummer [~Thunderbi@p200300DD672D1A3358F786CE8ECD7DD6.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 04:45 -!- TamasBlummer1 is now known as TamasBlummer 05:06 -!- icota [~igor@58-138.dsl.iskon.hr] has joined #rust-bitcoin 05:27 -!- icota [~igor@58-138.dsl.iskon.hr] has quit [Quit: Konversation terminated!] 06:59 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: Connection reset by peer] 07:00 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 07:22 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 07:40 -!- icota [~igor@58-138.dsl.iskon.hr] has joined #rust-bitcoin 09:09 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 09:58 < stevenroose> If I'm getting this when deserializing a transaction, what could that mean? `Io(Custom { kind: UnexpectedEof, error: StringError("failed to fill whole buffer") })` 10:05 < TamasBlummer> @andytoshi I am about to create a new file in rust-bitcoin for BIP157 filter messages, which made me wonder if we should consider update to the Copyright header of the files. Something along the lines of: And have a NOTICE or AUTHORS file for credits. 10:05 < TamasBlummer> // Rust Bitcoin Library 10:05 < TamasBlummer> // (c) 2014-2019 Rust Bitcoin developers 10:05 < TamasBlummer> // 10:05 < TamasBlummer> // To the extent possible under law, the author(s) have dedicated all 10:05 < TamasBlummer> // copyright and related and neighboring rights to this software to 10:05 < TamasBlummer> // the public domain worldwide. This software is distributed without 10:05 < TamasBlummer> // any warranty. 10:05 < TamasBlummer> // 10:05 < TamasBlummer> // You should have received a copy of the CC0 Public Domain Dedication 10:05 < TamasBlummer> // along with this software. 10:05 < TamasBlummer> // If not, see . 10:07 < TamasBlummer> Or is it a contradiction to CC0? 10:07 < TamasBlummer> maybe rather: 10:07 < TamasBlummer> // Written in 2014-2019 by Rust Bitcoin developers 10:10 < instagibbs> I don't think CC0 is public domain? 10:12 < TamasBlummer> I recon. therefore modified my suggestion to skip (c) and just write: 10:12 < TamasBlummer> // Written in 2014-2019 by Rust Bitcoin developers 10:12 < TamasBlummer> I am just reluctant to copy paste the existing headers as it is no longer correct to state Written by Andrew 10:30 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #rust-bitcoin 10:31 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host] 10:31 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 10:34 < stevenroose> TamasBlummer: I had the same thought when I created wif.rs for a PR. I think nowadays license headers are skipped anyway in most projects. The LICENSE file in the project root should be sufficient. 10:34 < stevenroose> But otherwise, I'd just have a brief referense to the LICENSE and AUTHORS file. 10:36 < stevenroose> Also, I think CC0 explicitly has authors waive copyright, so having a copyright notice is a bit contradictory. I mean it probably means "I, XXX, who has the legal right to claim copyright over YYY hereby waive it as per CC0.", but still. 10:39 < instagibbs> a "paper trail" is probably good, since as soon as you write something it's copyrighted in the US 10:39 * instagibbs wonders if an incompletely typed CC0 notice is copyrighted 10:44 < TamasBlummer> I am not after copyright, could not care less. Having AUTHORS or similar to give credit in addition to a neutral header would be nice. I consider that code I write is my legacy that survives me and at least my heirs will cheer to find my name associated with code that made a dent to the universe :) 11:05 < dongcarl> If people are free, please review https://github.com/rust-bitcoin/bitcoin_hashes/pull/29 11:05 < dongcarl> It fixes a panic in bitcoin_hashes 11:09 < gwillen> instagibbs: CC0 is "public domain if that is legal in your jurisdiction, otherwise an absolutely-permissive license designed to emulate the public domain" 12:41 < dongcarl> Thank you ariard 12:43 < ariard> dongcarl: you're welcome, will give a pass to #215 once updated if you need it 12:45 < dongcarl> ariard: You should review #215 now, as hashes/#29 doesn't change anything about #215, and we gotta wait for another hashes release before the tests will pass 12:45 < dongcarl> ariard: Lmk if you got things I can review for you! 12:50 < ariard> dongcarl: okay will do tonight, has to go in review mode for ln stuff too I think 12:51 < dongcarl> ariard: thanks dude, much appreciated. Feel free to assign me stuff to review. 13:20 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-eiscrdihrhnqdjjo] has quit [Quit: Connection closed for inactivity] 13:21 -!- michaels_ [~michaelsd@38.126.31.226] has joined #rust-bitcoin 13:24 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 240 seconds] 14:10 -!- michaels_ [~michaelsd@38.126.31.226] has quit [] 14:10 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 14:57 < BlueMatt> ariard: phew, got a few things merged today, diffs are way nicer now on the remaining 0.0.8-tagged things =D 14:58 < sgeisler> dongcarl: I was just going to complain why you didn't use the associated constant in the HashEngine trait to define the HMAC's ipad&opad size, just to notice that rust doesn't support it (and throws unhelpful errors) :crying: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=0d574a89f4fe5774a8ef0a135077e9df 14:58 < BlueMatt> TamasBlummer: I think I've generally always considered git log to be sufficient, but we can add an AUTHORS file if you like. I think the intent of the header there has pretty clear intent, enough that I dont think anyone would care about tweaking the text to be a bit more clear 14:58 < sgeisler> dongcarl: I was just going to complain why you didn't use the associated constant in the HashEngine trait to define the HMAC's ipad&opad size, just to notice that rust doesn't support it (and throws unhelpful errors) :crying: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=0d574a89f4fe5774a8ef0a135077e9df 14:59 < BlueMatt> wow thats mega unhelpful 14:59 < BlueMatt> I'm kinda surprised thats not supported even on stable 14:59 < BlueMatt> I would have figured thats the kind of thing that would have been added at some point 15:00 < BlueMatt> may be worth searching for/filing an issue with that somewhere upstream. Seems like an easy-ish change to make, but I may be missing things 15:00 < dongcarl> BlueMatt: I'm sure there's some obscure thing about some vtable or something that makes it hard to implement lol 15:01 < BlueMatt> maybe, doesnt mean its not worth having an issue to track it, though 15:01 < BlueMatt> at least they could make the error message more helpful 15:01 < BlueMatt> cause thats *really* bad 15:03 -!- sgeisler [~quassel@x8d1ee20a.agdsn.tu-dresden.de] has quit [Remote host closed the connection] 15:26 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:50 < dongcarl> andytoshi: Thanks for bumping hashes. Once you publish we can integrate rust-bitcoin with bitcoin_hashes!!!! =D 16:52 < ariard> BlueMatt: hey kool currently going through rust-bitcoin #215, then will pass on all 0.0.8 tagged things 17:56 < dongcarl> ariard: Thank you for reviewing my PR! 17:58 < dongcarl> ariard: BTW I don't know why GitHub says I dismissed your review... It just happens automatically when I force push I think 18:13 -!- sgeisler [~quassel@x8d1ee20a.agdsn.tu-dresden.de] has joined #rust-bitcoin 18:37 -!- icota_ [~igor@11-36.dsl.iskon.hr] has joined #rust-bitcoin 18:40 -!- icota [~igor@58-138.dsl.iskon.hr] has quit [Ping timeout: 240 seconds] 18:55 -!- AncientAardvark [~ShaunApps@c-76-26-29-34.hsd1.fl.comcast.net] has joined #rust-bitcoin 18:59 < ariard> dongcarl: yes seen the fix, unsafe use was my only real concern, as to stuff removed don't have real opinions 19:00 < ariard> BlueMatt: reviewed #295, will continue other 0.0.8-tagged things tomorrow 19:01 -!- AncientAardvark [~ShaunApps@c-76-26-29-34.hsd1.fl.comcast.net] has quit [Ping timeout: 268 seconds] --- Log closed Thu Jan 24 00:00:29 2019