--- Log opened Tue Feb 05 00:00:42 2019
02:41 < BlueMatt> ariard: so technically the block_connected/disconnected stuff you're supposed to call everything strictly in-order, so we "know" what the expected height is. I'm completely fine with adding the height explicitly, and also I'd eventually like to add some more checks on the input there to panic!() if called invalidly (ie connected/disconnected called out-of-order), which height would help with
02:41 < BlueMatt> sadly the tests currently violate this in a number of places, so would have to fix those first
04:24 -!- TamasBlummer1 [~Thunderbi@p200300DD672D1A01DDB20DCD68B12ACF.dip0.t-ipconnect.de] has joined #rust-bitcoin
04:26 -!- TamasBlummer [~Thunderbi@p200300DD672D1A29C99B660FFA62AD71.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
04:26 -!- TamasBlummer1 is now known as TamasBlummer
07:40 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #rust-bitcoin
07:40 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host]
07:40 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
11:57 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
11:58 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
12:33 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
12:37 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
12:41 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
12:44 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
14:00 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection]
14:03 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #rust-bitcoin
14:30 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
16:43 < ariard> Adding the height is to let the chain doing the math, and avoid us to count confirmations, and at least will add same check than one in block_connected
16:44 < ariard> Well don't have any problem to fix tests, already have to do due to taking account of safety reorg delay
18:11 -!- sgeisler [~quassel@x8d1ee20a.agdsn.tu-dresden.de] has quit [Ping timeout: 246 seconds]
23:04 -!- warren [~warren@fedora/wombat/warren] has quit [Ping timeout: 240 seconds]
23:05 -!- warren [~warren@fedora/wombat/warren] has joined #rust-bitcoin
--- Log closed Wed Feb 06 00:00:42 2019