--- Log opened Tue Feb 12 00:00:47 2019 02:56 < stevenroose> can I just reuse the impl_index_newtype macro for DerivationPath? that's be neat 02:58 < stevenroose> ah no I can't, because those return slices instead of new $thing's 03:08 < stevenroose> These more complex converts confuse me. I believe it should be possible to make the From work for both Vec and &[ChildNumber]. I thought AsRef could do something like that. But I never can figure those out without looking at examples :D 03:09 < stevenroose> (Given that ChildNumber has Copy, the AsRef should work and allow a &[ChildNumber] to be converted into a Vec when you implement From where T: AsRef<[ChildNumber]> right? 04:04 < stevenroose> sgeisler: I added quite a few trait impls that will let you do all kinds of things 04:05 < stevenroose> the only one that I couldn't was Index that returns a DerivationPath. Somehow the std::ops::Index has a `type Output` and then the `index()` method returns `&Self::Output`, so that would be a `&DerivationPath` and that wouldn't work. 04:06 < stevenroose> So I used the macro impl of Index that returns &[ChildNumber] slices instead. They can be `.into()`'d into DerivationPaths again. 04:06 < stevenroose> Then finally I also added `.child()` and `.into_child()`. 04:14 -!- TamasBlummer1 [~Thunderbi@p200300DD672D1A188521F124D96AD7C6.dip0.t-ipconnect.de] has joined #rust-bitcoin 04:16 -!- TamasBlummer [~Thunderbi@p200300DD672D1A4295EFE534E52DD1FC.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 04:16 -!- TamasBlummer1 is now known as TamasBlummer 04:18 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-vdyfomgoavmtovtu] has joined #rust-bitcoin 04:57 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-vdyfomgoavmtovtu] has quit [] 07:38 -!- michaels_ [~michaelsd@38.126.31.226] has joined #rust-bitcoin 07:50 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #rust-bitcoin 07:58 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Remote host closed the connection] 08:00 -!- michaels_ [~michaelsd@38.126.31.226] has joined #rust-bitcoin 08:08 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Remote host closed the connection] 08:09 -!- michaels_ [~michaelsd@38.126.31.226] has joined #rust-bitcoin 08:34 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ixfdpksazowvorpq] has joined #rust-bitcoin 08:46 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 11:59 < sgeisler> stevenroose: looks good, I think I will try to actually implement some use cases to get a feeling for the API 11:59 < sgeisler> the restriction to references as output values of index operation is really annoying 12:02 < dongcarl> stevenroose: I want our PRs to get merged faster (as long as there are still 2 approvals ofc), so that's why I asked to do a followup PR, but I will review! 12:03 < sgeisler> I'll review the DerivationPath PR after lunch 12:04 < sgeisler> (currently on eng call) 12:09 < stevenroose> cool 12:10 < stevenroose> dongcarl: yeah sorry just too many things changed for a followup IMO 12:37 -!- michael__ [~michaelsd@38.126.31.226] has joined #rust-bitcoin 12:40 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Ping timeout: 245 seconds] 12:52 < TamasBlummer> dongcarl: regarding https://github.com/rust-bitcoin/rust-bitcoin/pull/231 I helped to make it a useful class of its own. now I like it. 12:55 < dongcarl> TamasBlummer: It's quite well fleshed-out, and there are extensive tests 14:25 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ixfdpksazowvorpq] has quit [Quit: Connection closed for inactivity] 14:31 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #rust-bitcoin 15:15 -!- michael__ [~michaelsd@38.126.31.226] has quit [Read error: Connection reset by peer] 19:02 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #rust-bitcoin 20:34 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #rust-bitcoin 22:33 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds] --- Log closed Wed Feb 13 00:00:49 2019