--- Log opened Sat Feb 23 00:00:59 2019
03:58 -!- TamasBlummer1 [~Thunderbi@p200300DD672D1A07903003F435F19A79.dip0.t-ipconnect.de] has joined #rust-bitcoin
04:00 -!- TamasBlummer [~Thunderbi@p200300DD672D1A02159C132256BCD8B6.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
04:00 -!- TamasBlummer1 is now known as TamasBlummer
05:11 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
05:11 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
07:09 < andytoshi> dongcarl: i think we need another (minor) refactoring PR before PSBT :)
07:09 < andytoshi> everywhere in PSBT you need to replace secp256k1::PublicKey with util::key::PublicKey ... which transitively requires making the same change to the bip32 module
07:11 < andytoshi> i have two other comments that I put on the PR
07:11 < andytoshi> otherwise ACK
07:19 < stevenroose> andytoshi: how about replacing secp256k1::SecretKey with util::key::PrivateKey?
07:20 < stevenroose> It requires making decisions on compressedness, though
07:23 < andytoshi> stevenroose: oh, sure, we should also do that
07:23 < andytoshi> what kind of decisions? like, we need to choose a default
07:23 < andytoshi> that's fine IMO we should always use compressed keys in PSBTs we create
07:59 < stevenroose> andytoshi: I was looking at the bip32 side of that.
08:00 < stevenroose> When we derive an extended private key, it also contains the private key
08:00 < stevenroose> So we will also have to set a compressedness for that
08:00 < andytoshi> ah, i see
08:00 < andytoshi> yeah, i think we should do this, and we should set the compressedness to false by default
08:01 < andytoshi> err true
08:01 < andytoshi> and if somebody ever requests it i guess we could extend the API to add uncompressed key creation support
11:10 -!- amtraktoshi [462a9d17@gateway/web/freenode/ip.70.42.157.23] has joined #rust-bitcoin
12:28 -!- amtraktoshi [462a9d17@gateway/web/freenode/ip.70.42.157.23] has quit [Quit: Page closed]
--- Log closed Sun Feb 24 00:00:58 2019