--- Log opened Tue Feb 26 00:00:01 2019
01:30 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Remote host closed the connection]
01:30 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #rust-bitcoin
01:30 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
01:30 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin
01:34 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
01:39 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 255 seconds]
03:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
03:25 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
03:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
03:54 -!- TamasBlummer1 [~Thunderbi@p200300DD672D1A811DAA84F3733E24A2.dip0.t-ipconnect.de] has joined #rust-bitcoin
03:56 -!- TamasBlummer [~Thunderbi@p200300DD672D1A841DAA84F3733E24A2.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
03:56 -!- TamasBlummer1 is now known as TamasBlummer
04:28 -!- icota_ [~igor@141-136-128-148.dsl.iskon.hr] has joined #rust-bitcoin
04:30 -!- icota [~igor@141-136-128-148.dsl.iskon.hr] has quit [Ping timeout: 246 seconds]
04:30 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 246 seconds]
04:30 -!- sgeisler [~quassel@x8d1ee20a.agdsn.tu-dresden.de] has quit [Ping timeout: 246 seconds]
04:30 -!- sgeisler [~quassel@x8d1ee20a.agdsn.tu-dresden.de] has joined #rust-bitcoin
04:30 -!- instagibbs [~instagibb@100.15.135.248] has joined #rust-bitcoin
04:32 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
04:37 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
04:37 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
04:37 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
04:42 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds]
05:09 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
05:14 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 244 seconds]
05:41 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
05:46 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 240 seconds]
06:45 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
07:33 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-tqempquacvnrwdnh] has joined #rust-bitcoin
09:34 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
09:34 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
09:34 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
09:34 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
09:39 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
10:00 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
10:01 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
10:01 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
11:41 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
11:49 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-tqempquacvnrwdnh] has quit [Quit: Connection closed for inactivity]
11:54 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
12:30 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
12:34 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
12:38 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
12:43 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 258 seconds]
13:52 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
14:54 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin
14:55 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
14:55 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
14:55 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
14:57 -!- Guest60674 [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
15:01 -!- Guest60674 [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Ping timeout: 250 seconds]
16:14 -!- scoobybejesus is now known as asics
16:34 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
16:35 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
17:13 -!- asics is now known as scoobybejesus
17:59 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/238
18:00 < andytoshi> BlueMatt: dongcarl: oh, oops i missed the #bitcoin-core-dev stuff, was AFK. sometimes i can check IRC if somebody signals me
18:01 < andytoshi> stevenroose: dongcarl: can you review the PR i linked? i think it's fairly straightforward and should be all we need for PSBT
18:01 < andytoshi> well, after a rebase and some more changes to the psbt PR :)
18:02  * dongcarl looking
18:04 < dongcarl> andytoshi: You should take a look at the convo in bitcoin-core-dev... I'll see if I can find a link
18:05 < dongcarl> mainly the conversation was about the fact that BIP32 only supports compressed keys
18:06 < dongcarl> I was doing exactly your PR ytd and ran into a few problems I had to consult the BIP about
18:07 < andytoshi> dongcarl: iirc the bip is totally silent about compressedness
18:08 < andytoshi> i'd appreciate a link but nobody highlighted me (and apparently i don't highlight on rust-bitcoin .. guess i should fix that)
18:08 < dongcarl> gimme a sec
18:09 < dongcarl> convo starting at 325: http://www.erisian.com.au/bitcoin-core-dev/log-2019-02-25.html
18:09 < dongcarl> andytoshi:
18:11 < andytoshi> heh looks like sipa says to do exactly what i did
18:11 < dongcarl> I was confused because when I was implementing ckd_priv, I read the BIP and it specifically specified compressed serialization, whereas the BIP didn't say anything about the identifier
18:11 < andytoshi> right, i was able to get away without thinking about it by just passing to the `PublicKey::write_into()` function
18:12 < andytoshi> so if you somehow produce a extpub with an uncompressed key, it'll use that for the identifier
18:12 < andytoshi> but none of our functions will produce such a key..
18:12 < andytoshi> this may be the first time there's been a "don't think about it" edge case in core that hasn't been a problem for us ;)
18:14 < dongcarl> well, because the spec says to specifically do compressed serialization, shouldn't we do that regardless of the existing compressedness of the key?
18:14 < dongcarl> see the use of ser_P in the BIPs
18:14 < dongcarl> BIP*
18:15 < andytoshi> hmm
18:16 < dongcarl> hmm indeed
18:17 < andytoshi> ok, i can do that
18:17 < andytoshi> use `.key.serialize()` instead of `write_into`
18:17 < andytoshi> everywhere
18:17 < andytoshi> ah, i see, that's ok for ckd
18:18 < andytoshi> but the "identifier" section does not specifiy
18:18 < andytoshi> and it says "This corresponds exactly to the data used in traditional Bitcoin addresses" which strongly suggests to preserve compressedness
18:18 < andytoshi> ok. so i'll use `write_into` there.
18:19 < andytoshi> very interesting that the serialization format requires compressedness
18:20 < dongcarl> Lol yeah, I felt spidey senses tingling and it was good I checked BIP
18:21 < dongcarl> Anyways, I think my local working copy also has ExtendedPubkey switched over, I'll rebase over yours after it's merged
18:23 < andytoshi> force-pushed my code to use compressed keys in identifier() and serialization
18:23 < andytoshi> the FromStr impl already required compressedness because it only reads a 33-byte slice..
18:23 < andytoshi> i changed ckd to use compressed keys
18:23 < andytoshi> in the hmac input
18:24 < andytoshi> oh, no, i left identifier() alone ... but i believe there is literally no way to create an extpub with an uncompressed key
18:24 -!- TamasBlummer [~Thunderbi@p200300DD672D1A811DAA84F3733E24A2.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
18:24 < andytoshi> lol i guess you can by manually creating an ExtendedPubkey structure
18:24 < andytoshi> i think this is fine and matches the BIP
18:25 < andytoshi> s/matches/is consistent with/
18:25 < dongcarl> Maybe some day we'll have `--feature typesafe` that prevents people from shooting themselves in foot
18:26 < dongcarl> or perhaps `--feature gonuts`
18:27 < andytoshi> heh maybe. there's probably a pretty tight API we could come up with
18:28 < andytoshi> but let's get at least get the functionality we want for now..
18:33 < dongcarl> Yup
18:33 < dongcarl> Left a comment, will take a closer look tmr morning
18:43 < andytoshi> thanks, sounds good
21:02 -!- TamasBlummer [~Thunderbi@p200300DD674483221DAA84F3733E24A2.dip0.t-ipconnect.de] has joined #rust-bitcoin
--- Log closed Wed Feb 27 00:00:02 2019