--- Log opened Tue Mar 19 00:00:20 2019
01:01 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
01:04 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
01:36 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
01:37 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
01:41 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
02:05 -!- TamasBlummer1 [~Thunderbi@p200300DD670F9D17ED5E988679E4C8B5.dip0.t-ipconnect.de] has joined #rust-bitcoin
02:07 -!- TamasBlummer [~Thunderbi@p200300DD670F9D97ED5E988679E4C8B5.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
02:07 -!- TamasBlummer1 is now known as TamasBlummer
03:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
03:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
03:36 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
04:10 < stevenroose> andytoshi: ah I just noticed the same
04:10 < stevenroose> someone asked about it on rust-bitcoincore-rpc
04:10 < stevenroose> I PRd for PublicKey. Wasn't sure if we should have them on PrivateKey as well
05:04 < cjs77> andytoshi: The virus is spreading :) We've implemented MuSig in Pure Rust on top of Ristretto (Curve25519). https://github.com/tari-project/tari/blob/development/infrastructure/crypto/src/ristretto/musig.rs. Any thoughts / comments etc are welcome
05:52 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #rust-bitcoin
05:53 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
07:14 < andytoshi> stevenroose: lol, sorry, i should've mentioned that i was working on a PR as well
07:14 < andytoshi> i'll have it up in an hour or so ... going to do byte de/serialization for non-human-readable formats
07:14 < andytoshi> and also do private keys, because why not
07:15 < andytoshi> cjs77: nice :) i definitely don't have time to review it, and as always i'm suspicious of constant-time rust crypto, but i'm happy to hear that people are exploring musig
07:23 < stevenroose> andytoshi: what do you mean with "going to do byte de/serialization for non-human-readable formats"?
07:23 < stevenroose> PublicKeys are usually just hex, right?
07:23 < stevenroose> As with PrivateKeys, I assume WIF
07:24 < andytoshi> yeah, afaik the only format for private keys is WIF
07:24 < andytoshi> public keys are usually encoded as byte arrays
07:24 < andytoshi> hex is only for human-readable formats
07:36 < andytoshi> stevenroose: what do you think about https://github.com/rust-bitcoin/bitcoin_hashes/pull/38
07:37 < andytoshi> oh, i'm reading what your PR does, and i see it's actually completely unnecessary for this..
07:37 < andytoshi> but i'd like it anyway :)
07:47 < stevenroose> yeah it's not necessary. I know in theory it makes more sense to do bytes serialization for publickey, but sadly for json that means base64
07:50 < andytoshi> https://github.com/rust-bitcoin/rust-bitcoin/pull/246 is my version
07:50 < andytoshi> which has byte serialization, privatekey impls and unit tests
07:50 < andytoshi> (although, this style of unit test did not catch https://github.com/rust-bitcoin/bitcoin_hashes/pull/36 .. but idk how to test properly)
08:25 < dongcarl> I'm not very comfortable with https://github.com/rust-bitcoin/rust-bitcoin/pull/240
08:28 < dongcarl> It serves a very limited use case and imposes a large burden on developers to think about what requires secp and what doesn't
08:28 < dongcarl> I would like to know people's thoughts
08:30 < dongcarl> What stands out to me is that we now need to think about what `use`s are required by secp e.g. this hunk: https://github.com/rust-bitcoin/rust-bitcoin/pull/240/files#diff-7769ce7612a45cca417dce18a5aa6a50R22
08:30 < dongcarl> This makes it a little unreadable
08:30 < andytoshi> well, basically everything requires secp
08:30 < andytoshi> and if you're not insane, don't disable that feature
08:30 < andytoshi> i don't think it's too much of a burden
08:32 < andytoshi> maybe it is. i didn't read the PR too carefully, just checked that it didn't change any code
08:33 < dongcarl> Yeah let me know what you think
08:33 < andytoshi> i don't care about the PR at all, i basically acked it because i thought it was funny
08:33 < andytoshi> but if it's actually a burden we probably shouldn't merge it
08:38 < dongcarl> Haha yeah it is funny that this is even possible at all, but looking at the diff I feel it makes our code harder to work with
08:38 < dongcarl> BlueMatt: Would love your opinion on this
09:01 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #rust-bitcoin
09:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
10:00 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-nupfeeslcnexdoez] has joined #rust-bitcoin
12:38 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
13:50 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-nupfeeslcnexdoez] has quit [Quit: Connection closed for inactivity]
15:07 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 245 seconds]
15:55 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
16:05 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #rust-bitcoin
17:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
20:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
22:27 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
22:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
--- Log closed Wed Mar 20 00:00:21 2019