--- Log opened Mon Mar 25 00:00:25 2019
00:55 -!- ccdle12 [~ccdle12@116.92.188.38] has quit [Remote host closed the connection]
00:59 -!- ccdle12 [~ccdle12@116.92.188.38] has joined #rust-bitcoin
01:50 -!- ccdle12 [~ccdle12@116.92.188.38] has quit [Remote host closed the connection]
01:57 -!- TamasBlummer1 [~Thunderbi@p200300DD670F9D14C0A2B47CCEBA82CC.dip0.t-ipconnect.de] has joined #rust-bitcoin
01:58 -!- TamasBlummer [~Thunderbi@p200300DD670F9D08B10DA22A3C4687CB.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
01:58 -!- TamasBlummer1 is now known as TamasBlummer
02:31 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin
02:34 -!- TamasBlummer [~Thunderbi@p200300DD670F9D14C0A2B47CCEBA82CC.dip0.t-ipconnect.de] has quit [Quit: TamasBlummer]
02:40 -!- TamasBlummer [~Thunderbi@p200300DD670F9D146506B7C4D522E0CB.dip0.t-ipconnect.de] has joined #rust-bitcoin
05:09 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-zchkcmvmyfhzqhdp] has joined #rust-bitcoin
08:52 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 272 seconds]
09:45 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #rust-bitcoin
09:50 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Read error: Connection reset by peer]
10:27 < BlueMatt> ariard: should I just take https://github.com/rust-bitcoin/rust-lightning/pull/322 ?
10:34 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #rust-bitcoin
11:03 < ariard> BlueMatt: well other way would be to keep source for offered htlc on remote commitment tx, and avoid uncertainty thanks to htlc_id
11:04 < BlueMatt> nah, that would eat a lot of storage :/
11:04 < BlueMatt> see last comment, too
11:04 < BlueMatt> anyway, can you keep the claim logging and then I'll merge?
11:04 < ariard> agree too, so go ahead take it and will add warning comment in another PR
11:04 < BlueMatt> ariard: ^ (I mean can add a comment, too, but I'm less worried about it given its literally the same case as the top-level shit)
11:05 < BlueMatt> or, its impossible to differentiate, so whatever
11:05 < ariard> "can you keep the claim logging" sorry don't parse it?
11:06 < BlueMatt> if the new conditions are hit, log_claim!() is no longer called
11:06 < BlueMatt> so we dont get the log_info/log_error calls
11:07 < ariard> yeah right
11:08 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-zchkcmvmyfhzqhdp] has quit [Quit: Connection closed for inactivity]
11:17 < ariard> BlueMatt: updated, keep log_claim as a branch in case of not being Storage::Local mode
11:18 < BlueMatt> ariard: wait huh?
11:18 < BlueMatt> it still doesnt call log_claim if it hits the check_htlc_valid_remote cases
11:18 < ariard> BlueMatt: well in case of being a Watchtower
11:18 < BlueMatt> and also doesnt do the continue 'outer_loop if its in a local_tx?
11:19 < BlueMatt> hmm?
11:20 < ariard> arff, yes removing it, at least it will be in git history if we need it later
11:20 < BlueMatt> ok, I'm really confused?
11:21 < BlueMatt> I *think* it should be as it looked in the previous patch, but (a) if we set payment_data = ... we should *also* call log_claim (maybe with slightly new/different messages) and (b) if we fail to match in the !$local_tx cases we should still fall through to the } else { ... continue 'outer_loop } case
11:22 < BlueMatt> this would ensure we always call log_claim!() exactly once
11:29 < ariard> Hmm confused too, which are the tx we want to keep logging : tx spending received htlc output on remote revoked tx and
11:50 < ariard> BlueMatt: oh sorry got it, I think I completly misread your first intention and from then get confused, updated
11:52 < ariard> BlueMatt: on 305, will take times tonight to think if it takes a lot more work to add per-tx-that-claims tracking
12:07 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
12:59 -!- sgeisler [uid356034@gateway/web/irccloud.com/x-voyyrtoakmpswbfa] has joined #rust-bitcoin
15:03 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 250 seconds]
16:22 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
16:31 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin
16:35 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 246 seconds]
16:35 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #rust-bitcoin
16:35 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
16:35 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin
16:50 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 255 seconds]
16:50 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #rust-bitcoin
16:50 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
16:50 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin
17:10 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 250 seconds]
17:57 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #rust-bitcoin
17:57 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
17:57 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin
18:12 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
18:18 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 245 seconds]
18:36 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin
18:48 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
19:14 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 250 seconds]
--- Log closed Tue Mar 26 00:00:26 2019