--- Log opened Tue Mar 26 00:00:26 2019 01:56 -!- TamasBlummer1 [~Thunderbi@p200300DD670F9D186506B7C4D522E0CB.dip0.t-ipconnect.de] has joined #rust-bitcoin 01:58 -!- TamasBlummer [~Thunderbi@p200300DD670F9D146506B7C4D522E0CB.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 01:58 -!- TamasBlummer1 is now known as TamasBlummer 08:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 08:13 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin 08:33 < stevenroose> andytoshi: what is Decimal used for in rust-bitcoin? 09:00 < BlueMatt> ariard: I mean if https://github.com/rust-bitcoin/rust-lightning/pull/305 is gonna keep making progress then we can just wait for that for 0.0.9, the only reason I opened a new version was cause I figured TamasBlummer may want a version bump to bump the rust-bitcoin dependency 09:41 < stevenroose> hmm, I had this before, what does it mean when you try running the unit tests with rust v1.24.0 and it hangs forever? 09:41 < stevenroose> ah, just seemd to be slow 09:46 -!- will__ [6b01edea@gateway/web/freenode/ip.107.1.237.234] has joined #rust-bitcoin 09:58 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 09:58 -!- will__ [6b01edea@gateway/web/freenode/ip.107.1.237.234] has quit [Quit: Page closed] 10:00 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 10:01 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 10:05 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 10:25 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 10:29 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 245 seconds] 10:31 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:15 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:16 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:20 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 14:21 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:22 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:22 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:25 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:26 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:30 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 245 seconds] 14:38 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:42 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 244 seconds] 14:50 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 15:40 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 16:08 < andytoshi> stevenroose: Decimal is used for amounts in the RPC 16:57 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 16:59 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 17:03 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 17:17 < ariard> BlueMatt: yes see https://github.com/rust-bitcoin/rust-lightning/pull/305#discussion_r268918453, actually I'm fixing your other comment and nits 17:18 < ariard> I'm gonna implement the per-HTLC-by-tx tracking stuff on top of it, but will submit in another PR 17:19 < BlueMatt> ariard: wait huh 17:20 < ariard> yes ? 17:20 < BlueMatt> ariard: yea, I'm saying we *dont* want to revoke on the basis of the height? 17:20 < BlueMatt> we want to wait until we see the transaction get confirmed 17:20 < BlueMatt> and *then* wait on the height? 17:20 < BlueMatt> or am I misunderstanding your comment 17:20 < BlueMatt> (sorry, my head's pretty foggy with a bit of a fever) 17:21 < ariard> IMO, what I'm trying to explain in my last comment is that backfailing stuff and bumping tx are 2 diifferent things 17:22 < ariard> but some of this could-be bumped tx can be the failure-trigger tx 17:22 < BlueMatt> i mean kinda, but both start with tracking the tx 17:22 < BlueMatt> (imo) 17:22 < BlueMatt> if you disagree/have a different path forward in mind, then i can merge as-is first 17:22 < ariard> BlueMatt: so I think we want to revoke on the basis of height 17:23 < BlueMatt> yes, but height after the transaction that gets us our money back is confirmed 17:23 < ariard> well yes for non-dust HTLC 17:23 < BlueMatt> not based on the height of where we can start to claim our money back 17:23 < BlueMatt> yea, sure 17:23 < BlueMatt> for dust right away 17:24 < ariard> I think we kinda agree, just there is different sources of failure tx 17:26 < ariard> BlueMatt: the case you point in your comment is revoked tx, where if your sutff isn't broken, we should always succeed to get our money back 17:26 < BlueMatt> well, I mean hopefully 17:26 < BlueMatt> but no reason to fail back until we're sure 17:26 < ariard> (but we already have this discussion around end of december I think 17:26 < BlueMatt> and, hell, if we dont and they somehow claim, then your new code will let us fulfill back =D 17:28 < ariard> yes I'm gonna to implement tracking of HTLC tx, it may lighten the issue 17:29 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 17:30 * BlueMatt -> dinner 17:31 < BlueMatt> I meant https://github.com/rust-bitcoin/rust-lightning/pull/325 will let us fulfill, so we should wait until confirmation, otherwise that code wont help us much 17:37 < ariard> Yes, will modify the ugly 322 test to check confirmation once 305 has landed 17:37 -!- willpiers [~willpiers@73.95.135.44] has joined #rust-bitcoin 17:41 -!- willpiers [~willpiers@73.95.135.44] has quit [Ping timeout: 250 seconds] 18:08 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 18:13 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 268 seconds] 18:33 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 18:46 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 18:47 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 19:07 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 19:14 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 19:14 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 19:16 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 245 seconds] 19:18 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 245 seconds] 19:23 < ariard> BlueMatt: 305 updated for new review/taking it further 19:24 < ariard> I hope to finish a first milling of per-HTLC-claim-tx tracking stuff tomorrow evening 19:48 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 21:04 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 21:04 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 21:06 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 21:06 -!- willpier_ [~willpiers@38.75.231.30] has joined #rust-bitcoin 21:57 -!- willpier_ [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 21:57 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 22:01 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 255 seconds] --- Log closed Wed Mar 27 00:00:27 2019