--- Log opened Mon Apr 01 00:00:32 2019 01:44 -!- TamasBlummer1 [~Thunderbi@p200300DD670F9D126506B7C4D522E0CB.dip0.t-ipconnect.de] has joined #rust-bitcoin 01:46 -!- TamasBlummer [~Thunderbi@p200300DD670F9D846506B7C4D522E0CB.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 01:46 -!- TamasBlummer1 is now known as TamasBlummer 02:07 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Remote host closed the connection] 02:07 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin 04:04 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 04:09 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 255 seconds] 06:45 < stevenroose> andytoshi, sgeisler, bitcoin_hashes authors, I have a question. In Elements we (Mark Friedenbach legacy apparently) use a special kind of hash for merkle tree calculations. It's like a double-(sha256-midstate), algo here: https://github.com/ElementsProject/elements/blob/master/src/primitives/txwitness.cpp#L50 06:46 < stevenroose> What's your opinion about what value to use for that? sha256::Hash, sha256d::Hash? I would prefer to avoid plain [u8; 32] because I'm using it in a JSON context.. 06:46 < stevenroose> Changing this to a regular sha256d merkle root is on the hardfork wishlist, but that can take a while :) 07:03 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:40 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 07:40 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:45 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 268 seconds] 07:46 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 246 seconds] 07:46 < andytoshi> don't we have a Midstate type in the Hash trait for exactly this? 07:47 < andytoshi> i think `::Midstate` is the correct type 07:47 < andytoshi> oh, the _Engine_ has a midstate 07:48 < andytoshi> `sha256::Engine::MidState` then 07:48 < andytoshi> which, btw, is actually a [u8; 32] 07:49 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #rust-bitcoin 07:59 < BlueMatt> ariard: " on CPFP, okay so remote output is there to let him bump your local commitment tx" <-- essentially, yes 08:00 < BlueMatt> ariard: "and aren't also HTLC-Success/HTLC-Timeout txn concerned by your CPFP prop, being countersigned by remote" <-- yea, they'd probably need something similar, I havent thought that far out 08:05 < stevenroose> andytoshi: heh, cool that there is a type :D but if it's a type alias it's not more useful than a plain array for json purposes 08:06 < andytoshi> if you use the alias you'll be a bit more protected in case it changes ever 08:06 < andytoshi> and it'll be a bit clearer to readers of your code 08:18 < stevenroose> I think in this case, I'm gonna ignore the principle difference and just use sha256d::Hash as the type :| 08:19 < stevenroose> Btw, this is annoying: the trait `bitcoin::consensus::Decodable>` is not implemented for `elements::transaction::Transaction` 08:19 < stevenroose> When I have a project using a different rust-bitcoin version than elements, I can't decode elements types. 08:20 < andytoshi> fortunately there is a version of rust-elements for every version of rust-bitcoin.. 08:20 < stevenroose> I've never seen any Cargo.toml files using the ">=0.17.0" for dependencies. 08:20 < andytoshi> and most of the rust-elements versions differ only in this respect 08:20 < stevenroose> ah didn't know there was! 08:20 < andytoshi> nor have i. where is that? 08:21 < andytoshi> stevenroose: yeah, i think since rust-bitcoin 0.14 at least 08:22 < stevenroose> andytoshi: nowhere, that was the default in Go and Dart package managers, I think npm too. But those are runtime languages where your entire runtime can use only one version of every dependency. 08:22 < andytoshi> ah! 08:22 < andytoshi> yeah that sounds insane 08:22 < stevenroose> but ok, that solves it, just needs to bump elements accordingly 08:22 < andytoshi> and maybe explains why go has such a weak type system 08:27 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 09:27 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #rust-bitcoin 09:33 < stevenroose> dpc: if you have a minute, I'm trying to get those PRs through for rust-bitcoincore-rpc 11:55 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 12:49 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:34 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:45 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 15:02 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 15:18 < stevenroose> dpc: there's more of them ;) 15:25 < stevenroose> dpc: thanks :) 15:26 < dpc> stevenroose: I'm done? :D 15:36 < stevenroose> dpc: one last thing: the release PR: https://github.com/rust-bitcoin/rust-bitcoincore-rpc/pull/33 15:36 < stevenroose> dpc: JSON-RPC batching will be for next release, I'll think about a redesigned API 15:37 < stevenroose> I'll wait until tomorrow to merge it, so take your time 15:46 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 15:46 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 15:46 -!- willpier_ [~willpiers@38.75.231.30] has joined #rust-bitcoin 16:06 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 246 seconds] 16:14 -!- willpier_ [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 16:35 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 16:39 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 250 seconds] 16:46 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 16:59 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #rust-bitcoin 19:15 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 19:20 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 250 seconds] 20:20 -!- ccdle12 [~ccdle12@223.197.182.203] has joined #rust-bitcoin 20:22 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 20:53 -!- ccdle12 [~ccdle12@223.197.182.203] has quit [Read error: Connection reset by peer] 20:54 -!- ccdle12 [~ccdle12@223.197.182.203] has joined #rust-bitcoin 22:21 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 22:22 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 22:26 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 244 seconds] 22:26 -!- ccdle12 [~ccdle12@223.197.182.203] has quit [Read error: Connection reset by peer] 22:27 -!- ccdle12 [~ccdle12@223.197.182.203] has joined #rust-bitcoin 22:51 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 22:53 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 23:11 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #rust-bitcoin 23:15 -!- ccdle12 [~ccdle12@223.197.182.203] has quit [Remote host closed the connection] --- Log closed Tue Apr 02 00:00:33 2019