--- Log opened Wed Apr 03 00:00:34 2019 00:14 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 00:14 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 01:41 -!- TamasBlummer1 [~Thunderbi@p200300DD670F9D108B63F3EA8BC14A79.dip0.t-ipconnect.de] has joined #rust-bitcoin 01:43 -!- TamasBlummer [~Thunderbi@p200300DD670F9D256506B7C4D522E0CB.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 01:43 -!- TamasBlummer1 is now known as TamasBlummer 02:07 < stevenroose> so about the Amount type: andytoshi BlueMatt sgeisler... 02:08 < stevenroose> Currently it's so that you can chose satoshi or millisatoshi precision (using i64) 02:08 < stevenroose> I think in the comments there was arguments against having msat by default because it would make the conversion to satoshi more expensive 02:09 < stevenroose> (decimal shift) 02:10 < stevenroose> So do we want to (1) totally disregard Lightning and just use a simpler amount with satoshis, (2) disregard this performance trade-off and have a simpler amount that does msat or (3) revisit the configurable implementation (as is in the RFC PR now)? 02:11 < stevenroose> I really kinda need this type, the bitcoin-amounts crate type is horribly bad when it comes to conversion. You just can't get the btc-denominated value from it in any way and that's what the JSON-RPC expects. So I can't use it at all currently for bitcoincore_rpc or liquid_rpc. 02:11 < stevenroose> Unless I 02:11 < stevenroose> Unless I'm gonna implement conversion logic ad-hoc on the type, which I'd like to avoind. 02:37 < sgeisler> stevenroose: by now I think that a kiss solution would be best: two types `BitcoinAmount` and `LightningAmount` in rust-bitcoin and `From` impls in both directions. I don't like having the lightning one in rust-bitcoin directly, but to have conversions that seems necessary :/ 02:38 < sgeisler> Maybe we could even put he lightning amount into rust-lightning, we might not want to convert it to btc amounts without specifying the rounding strategy anyway 03:09 < stevenroose> sgeisler: that sounds reasonable. it's true that Rust's `.into()` makes having two separate types quite doable 03:09 < stevenroose> on it! 05:09 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 05:13 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 05:36 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 06:12 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 06:22 < andytoshi> sgtm 06:23 < andytoshi> as a historical note, bitcoin's `Amount`, if it's the type i made, had nothing to do with millisatoshis...that was not even a concept in my head at the time 06:23 < andytoshi> it was me trying to work with core RPC and totally overengineering it 06:32 -!- willpier_ [~willpiers@38.75.231.30] has joined #rust-bitcoin 06:38 -!- willpier_ [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 06:40 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 06:40 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 07:27 < stevenroose> andytoshi: you mean Decimal? 07:27 < stevenroose> Because the current Amount type is in the bitcoin-amount crate and is unrelated to rust-bitcoin. It's also not a very convenient API. 07:27 < stevenroose> So I did a re-take and ditched msat entirely: https://github.com/rust-bitcoin/rust-bitcoin/pull/252 07:27 < stevenroose> sgeisler: BlueMatt: ^ 07:29 < stevenroose> I'm looking into what extra unit tests are worth having. I feel like very exhaustively ensuring all floating-point conversions is a bit overkill because we should discourage floating-point. Even though it's used with the Core RPC.. 07:39 < andytoshi> oh yeah i did mean Decimal 07:46 < stevenroose> yeah so this type mostly has stuff to do fancyness regarding denominations (like you can fmt and string into a denomination, also parse) and has more sane serde integration by requiring you to explicitly indicate how you expect serde to parse it 07:47 < stevenroose> like you can't just serde Amount without specifying "as_sat" or "as_btc". Because both are used in APIs and would be bad to only support one or have a special case for the other 08:01 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 08:06 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 08:14 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 09:12 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 09:25 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 09:26 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 09:36 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 09:44 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 09:46 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 09:50 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 10:02 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 10:35 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 10:39 -!- mlerner [uid356390@gateway/web/irccloud.com/x-psgveavixrrydegn] has quit [Quit: Connection closed for inactivity] 10:41 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 10:42 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 10:42 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 11:13 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:13 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 11:18 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 11:25 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 11:34 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:40 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 11:44 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:55 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 12:11 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 12:12 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 12:12 -!- jtimon [~quassel@59.31.134.37.dynamic.jazztel.es] has joined #rust-bitcoin 13:31 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 13:57 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:02 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 245 seconds] 14:04 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:13 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:15 < BlueMatt> ariard: whats the status of #305? 14:16 < BlueMatt> ariard: should I be waiting on the change to txid-indexing before reviewing it again? 14:17 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 14:36 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:40 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 245 seconds] 14:45 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:57 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 15:46 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 16:01 < ariard> BlueMatt: #305 is ready since few days, I did some changes of the data struct in #333, but there are more bump-tx stuff related 16:02 < ariard> BlueMatt: got some unexpected household stuff to manage this week, nothing important but ddos my workflow, and should be travelling until end of week 16:02 < ariard> nevertheless available tonight and tomorrow too 16:34 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 16:58 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 16:59 -!- DeanWeen is now known as DeanGuss 17:39 -!- gwillen [~gwillen@unaffiliated/gwillen] has quit [Read error: Connection reset by peer] 17:39 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #rust-bitcoin 17:57 -!- jtimon [~quassel@59.31.134.37.dynamic.jazztel.es] has quit [Quit: gone] 21:47 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 22:01 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 22:01 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 22:02 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 22:10 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 22:14 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 250 seconds] 22:27 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #rust-bitcoin 23:20 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 23:47 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 23:48 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 23:49 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 23:53 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 244 seconds] --- Log closed Thu Apr 04 00:00:35 2019