--- Log opened Thu Apr 04 00:00:35 2019 00:28 -!- gwillen [~gwillen@unaffiliated/gwillen] has quit [Ping timeout: 245 seconds] 00:29 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 00:29 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #rust-bitcoin 00:46 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Disconnected by services] 00:49 -!- mol [~molly@unaffiliated/molly] has joined #rust-bitcoin 00:49 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has joined #rust-bitcoin 00:51 -!- molz [~molly@unaffiliated/molly] has quit [Ping timeout: 268 seconds] 00:52 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 00:52 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 00:57 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 245 seconds] 00:58 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 01:00 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ovkxsqycyzmhytku] has joined #rust-bitcoin 01:42 -!- TamasBlummer1 [~Thunderbi@p200300DD670F9D416506B7C4D522E0CB.dip0.t-ipconnect.de] has joined #rust-bitcoin 01:45 -!- TamasBlummer [~Thunderbi@p200300DD670F9D108B63F3EA8BC14A79.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 01:45 -!- TamasBlummer1 is now known as TamasBlummer 02:23 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has quit [Remote host closed the connection] 02:27 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has joined #rust-bitcoin 02:31 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has quit [Ping timeout: 246 seconds] 02:43 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has joined #rust-bitcoin 02:45 < stevenroose> solving serde mess for Amount 02:45 < stevenroose> I forgot to add the `::opt` variants to solve `Option` 02:57 < stevenroose> Wtf, just adding serde_json as a dependency, these sudden compiler errors show up: https://gist.github.com/stevenroose/79c956123be66815de9813929eb49068 03:39 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has quit [Remote host closed the connection] 03:43 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has joined #rust-bitcoin 03:52 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has quit [Ping timeout: 258 seconds] 03:57 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has joined #rust-bitcoin 03:57 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has quit [Read error: Connection reset by peer] 03:57 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has joined #rust-bitcoin 04:03 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has quit [Remote host closed the connection] 04:24 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has joined #rust-bitcoin 05:19 -!- neonknight64 [~neonknigh@195.159.29.126] has joined #rust-bitcoin 05:22 -!- neonknight [uid318979@gateway/web/irccloud.com/x-dvyajikcklcwzwsw] has quit [] 05:26 -!- mikethetike [sid308076@gateway/web/irccloud.com/x-xhkjhhkgwsrbaocd] has quit [] 05:26 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has quit [Remote host closed the connection] 05:31 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has joined #rust-bitcoin 05:31 -!- neonknight64 is now known as neonknight 05:31 -!- simian_za [sid314183@gateway/web/irccloud.com/x-tqjbectcwaqhgqvb] has quit [] 05:32 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has quit [Remote host closed the connection] 05:33 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has joined #rust-bitcoin 05:39 -!- simian_za [~simian_za@195.159.29.126] has joined #rust-bitcoin 05:46 -!- ccdle12 [~ccdle12@pcd290036.netvigator.com] has quit [Remote host closed the connection] 07:02 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:21 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 07:31 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:34 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 07:40 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:40 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 07:41 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:43 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 07:43 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:44 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 07:44 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:48 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 245 seconds] 07:54 < dongcarl> stevenroose: Hey, I've been intending to review `Amount` type, but once you've got details sorted out, would you mind breaking up the second commit some more? 07:58 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 08:12 < stevenroose> I fixed those dongcarl (the first is not part of the PR (it's the strason PR), so yeah it's one commit 08:12 < stevenroose> but it's one file too, and a new file 08:12 < stevenroose> not sure how it would make sense to break it up, I could just split in in 3 parts: impl, serde, test? but that's the same as just scrolling past it.. 08:37 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 08:41 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 09:30 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 09:44 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 09:45 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 09:50 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 10:02 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 10:06 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 10:12 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 10:52 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 10:53 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 11:23 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:26 -!- willpier_ [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 11:30 -!- willpier_ [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 11:34 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 11:42 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:50 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 13:06 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 13:16 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 13:28 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ovkxsqycyzmhytku] has quit [Quit: Connection closed for inactivity] 14:44 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:45 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:46 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:46 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has joined #rust-bitcoin 14:49 -!- willpiers [~willpiers@107-1-237-234-ip-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 15:32 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 16:27 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 17:32 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 18:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 18:26 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 20:34 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 20:56 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 21:10 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #rust-bitcoin 22:09 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 22:09 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 22:14 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 246 seconds] 23:31 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-virduqbfmazjfdqw] has quit [Read error: Connection reset by peer] 23:42 -!- dpc [dpcmatrixo@gateway/shell/matrix.org/x-hqsoryqzhlwmpgzx] has joined #rust-bitcoin --- Log closed Fri Apr 05 00:00:36 2019