--- Log opened Wed Apr 10 00:00:43 2019 01:31 -!- TamasBlummer1 [~Thunderbi@p200300DD670F9D486506B7C4D522E0CB.dip0.t-ipconnect.de] has joined #rust-bitcoin 01:33 -!- TamasBlummer [~Thunderbi@p200300DD670F9D25075A8AC994230C84.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 01:33 -!- TamasBlummer1 is now known as TamasBlummer 01:42 -!- ccdle12_ [~ccdle12@175.45.54.238] has quit [Remote host closed the connection] 02:36 < stevenroose> Quick Rust question: If you want a method to take a String, but also allow calling it with &str to avoid `to_owned()` everywhere, would there be a way to do `method>(s: S)` and then not reallocate when s was a String? When doing `s.as_ref().to_owned()`, I think the string is reallocated. 03:00 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 03:05 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 250 seconds] 03:14 -!- CjS7783 is now known as CjS77 04:20 < sgeisler> stevenroose: I'd use `Cow`, imo it shouldn't allocate: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=3bbda7e522f1864b8053cac7f691e0b9 04:23 < sgeisler> this makes it a bit more apparent: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=96bb011244f35831639ed34f15bd4d2d 05:38 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ldumahbvmuagxtpp] has joined #rust-bitcoin 07:02 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:07 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 246 seconds] 07:18 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:23 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 07:45 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 07:45 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 07:45 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 08:38 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 11:05 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 11:35 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 11:36 -!- willpiers [~willpiers@38.75.231.30] has quit [Read error: Connection reset by peer] 11:36 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 11:57 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 255 seconds] 12:02 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #rust-bitcoin 12:15 < BlueMatt> ariard: hmmm, I kinda want to just skip 305 and merge 333... 12:16 < BlueMatt> given 333 removes a few things from 305 that I'm not a fan of :p 12:16 < BlueMatt> can you do 333 without the bump implementation stuff and I'll merge that while you work on the bump implementation stuff? 12:16 < BlueMatt> (or I can just wait for it and do it all at once) 12:41 < stevenroose> I'm having trouble finding a suitable way to convert floats to Amounts and detect too high precision. F.e. 10 msat or 0.123456781 BTC. I'm thinking the easiest is just to convert to string and use the parse method. Only other way I could think of is to somehow take the fractal value of the satoshi-scaled float and compare it to f64::EPSILON, but I think then you can easily hit that with just using a 12:41 < stevenroose> sum or so 12:41 < stevenroose> And I don't feel confident in any multiplicator to EPSILON 13:38 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 13:48 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 13:51 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 14:04 -!- mol [~molly@unaffiliated/molly] has quit [Quit: ZNC 1.7.0 - https://znc.in] 14:04 -!- molz [~molly@unaffiliated/molly] has joined #rust-bitcoin 14:24 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 14:54 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 15:05 < ariard> BlueMatt: like this https://github.com/rust-bitcoin/rust-lightning/pull/336 ? 15:12 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 15:33 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ldumahbvmuagxtpp] has quit [Quit: Connection closed for inactivity] 15:56 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 16:19 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 16:54 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 16:55 -!- harding [~quassel@li1258-130.members.linode.com] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 16:56 -!- harding [~quassel@li1258-130.members.linode.com] has joined #rust-bitcoin 17:34 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds] 17:35 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 17:37 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #rust-bitcoin 18:09 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 18:10 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 18:10 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 21:42 -!- willpiers [~willpiers@38.75.231.30] has quit [Remote host closed the connection] 21:43 -!- willpiers [~willpiers@38.75.231.30] has joined #rust-bitcoin 21:47 -!- willpiers [~willpiers@38.75.231.30] has quit [Ping timeout: 255 seconds] 23:47 -!- ccdle12 [~ccdle12@223.197.137.165] has joined #rust-bitcoin --- Log closed Thu Apr 11 00:00:41 2019