--- Log opened Sat Jun 29 00:00:56 2019
00:40 -!- reallll is now known as belcher
01:28 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
02:40 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
02:40 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin
04:59 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds]
05:09 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
08:46 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
08:47 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
10:38 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
10:38 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
11:13 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-rbbplyxmhnjpwjbt] has joined #rust-bitcoin
13:41 < andytoshi> stevenroose: so, been thinking about `.pop_opcode()` and i think i can only make it work once
13:41 < andytoshi> without using O(n) space (by keeping a stack of everything pushed) or O(n) time (by rescanning)
13:42 < andytoshi> and i continue not to understand why it's "dangerous" to use a script builder without separately keeping track of all the opcodes you're pushing
13:43 < gwillen> I think it would be reasonable to say that any safe use _could_ track all the opcodes being pushed -- it might be unsafe to try to use a script builder to push a combination of untrusted input and your own stuff
13:44 < gwillen> I think that's clearly not happening here but it's kind of what the thing you asked for sounds like on casual inspection
13:44 < andytoshi> i need someone to be way more explicit about that
13:44 < gwillen> but I think it also makes sense to not force callers to actually track all the opcodes being pushed, even given that they are in fact building the script themselves and could do so if they wanted to, because in your application it's a waste of effort
13:44 < andytoshi> you can already do .push_opcode(opcodes::all::VERIFY)
13:44 < andytoshi> this literally just saves a byte sometimes
13:45 < andytoshi> the relationship to "untrusted input" mystifies me
13:46 < andytoshi> "why do we have .push_num? if the user doesn't know what number it is so they can manually push OP_1 OP_2 etc then they're doing unsafe things"
13:46 < gwillen> yeah I dunno, I think it's clear that the argument against is "this feature appears designed to allow you to edit a script you got from somewhere else, which is something you probably shouldn't be doing"
13:46 < gwillen> except that it's clear that's not why you want it
13:46 < andytoshi> lol how can you get a script::Builder from somewhere else
13:46 < andytoshi> you can't even serialize it
13:47 < andytoshi> or deserialize it
13:47 < gwillen> and also you are correct that there are lots of other ways to do stupid things with script builder
13:47 < gwillen> so I see no reason to prohibit this one
13:47 < andytoshi> furthermore, as evidenced by the bug in the PR, this is subtle and hard to get right, so really the library should be helping the user
13:48 < gwillen> *nods*
13:52 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
14:03 -!- harding [~harding@c-73-196-98-36.hsd1.nj.comcast.net] has quit [Ping timeout: 246 seconds]
14:13 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-rbbplyxmhnjpwjbt] has quit [Quit: Connection closed for inactivity]
15:01 -!- harding [~harding@c-73-196-98-36.hsd1.nj.comcast.net] has joined #rust-bitcoin
15:32 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
17:56 -!- harding [~harding@c-73-196-98-36.hsd1.nj.comcast.net] has quit [Ping timeout: 248 seconds]
19:10 -!- TamasBlummer1 [~Thunderbi@p200300DD6712641845DA1387D916D8DD.dip0.t-ipconnect.de] has joined #rust-bitcoin
19:12 -!- TamasBlummer [~Thunderbi@p200300DD67126454644A77A296CC6C27.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
19:12 -!- TamasBlummer1 is now known as TamasBlummer
19:47 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving]
19:49 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
21:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
--- Log closed Sun Jun 30 00:00:14 2019