--- Log opened Fri Jul 05 00:00:02 2019 00:37 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 01:43 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 01:46 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 01:52 -!- reallll is now known as belcher 02:39 < stevenroose> :D 02:39 < stevenroose> andytoshi: does Matt's encoding cleanup PR remove the generics on Encodable and Decodable? I just tried adding a `deserialize_hex` method and it doesn't seem possible, which is quite frustrating :/ 03:20 < stevenroose> TamasBlummer: I made another round of comments on your bip158 PR. Mostly things not conform with rust-bitcoin coding style and so. 04:20 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 04:35 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 04:52 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 04:56 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 248 seconds] 05:43 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 05:47 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 244 seconds] 06:27 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 06:28 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 06:54 < andytoshi> stevenroose: it removed a bunch of blanket impls 06:54 < andytoshi> i'm curious what trouble you're running into now with deserialize_hex ... my intuition is that even sealing the traits shouldn't make that hard 07:23 < andytoshi> stevenroose: i think we way to do this migth be to add a HexReader to bitcoin_hashes which wraps a normal Reader 07:23 < andytoshi> and we should also change the deserialize function to take a Read rather than a slice 08:38 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-yrjyomrchtwrguoi] has joined #rust-bitcoin 10:10 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 10:31 < andytoshi> sgeisler: can you take a look at https://github.com/rust-bitcoin/bitcoin_hashes/pull/52 ? 10:58 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-yrjyomrchtwrguoi] has quit [Quit: Connection closed for inactivity] 11:24 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 11:24 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 11:29 < sgeisler> andytoshi: will have a look later, can't right now 11:48 < andytoshi> great, thanks! i guess it's 9p on a friday for you. have a good weekend! 14:26 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 14:30 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 252 seconds] 16:29 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ryliiiaqzehslhzg] has joined #rust-bitcoin 17:01 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #rust-bitcoin 17:10 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 17:43 -!- e4xit_ [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #rust-bitcoin 17:43 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 245 seconds] 18:39 -!- e4xit_ [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 248 seconds] 19:03 -!- TamasBlummer1 [~Thunderbi@p200300DD6712642699E9A519C81BD145.dip0.t-ipconnect.de] has joined #rust-bitcoin 19:05 -!- TamasBlummer [~Thunderbi@p200300DD67126462DC06BCCDD8400259.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 19:05 -!- TamasBlummer1 is now known as TamasBlummer 20:23 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 20:58 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ryliiiaqzehslhzg] has quit [Quit: Connection closed for inactivity] 22:34 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 22:38 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 258 seconds] --- Log closed Sat Jul 06 00:00:08 2019