--- Log opened Mon Jul 22 00:00:18 2019 00:22 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 246 seconds] 00:29 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #rust-bitcoin 00:29 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host] 00:29 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin 01:24 -!- Everett35Schille [~Everett35@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 04:47 -!- Everett35Schille [~Everett35@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 245 seconds] 05:40 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 07:07 < andytoshi> stevenroose: published bitcoin_hashes 0.7.0 07:07 < andytoshi> sorry for the delay, i went offline for the weekend 07:38 < stevenroose> me too, so no worries :) it's just removing the ::hex from some lines :) 07:43 < stevenroose> What was the solution to parsing 0-input transactions gotten from Bitcoin Core? 07:43 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin 07:44 < andytoshi> we require they use segwit serialization even though they have no witnesses 07:47 < andytoshi> which is against sipa's advice, which is "add a context flag to all serialization code to force/unforce segwit selection, and in some cases attempt deserialization both ways" 07:56 -!- CjS77 [~caylemeis@195.159.29.126] has quit [Ping timeout: 272 seconds] 09:46 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 09:49 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 246 seconds] 09:52 -!- reallll is now known as belcher 10:10 < ariard> BlueMatt: replied you back on #348, we mostly just need to agree on how we interpret spec 10:10 < ariard> once done, will rebase #349 and #355 10:11 < ariard> rn rewriting bump stuff following merge of #336 10:44 < BlueMatt> ariard: hmm, did I forget what we'd talked about? 11:03 < ariard> BlueMatt: previously on the PR thread ? No IMO it's different specs cases 11:17 < BlueMatt> ariard: ohoh, right 11:17 < BlueMatt> let me re-review 11:30 -!- drolmer [~drolmer@unaffiliated/drolmer] has joined #rust-bitcoin 11:35 < BlueMatt> ariard: left a review 11:35 < BlueMatt> almost good 12:32 < ariard> BlueMatt: updated at 48e2ce2, but not sure if you were on last tip 12:59 < BlueMatt> will look again 13:04 < BlueMatt> ariard: if you're gonna expose something only for fuzzing, can you #[cfg(feature = "fuzztarget")]? 13:06 < BlueMatt> ariard: the extra len() == 0 is still on the latest I see? 13:45 < ariard> Ooops, my bad forgot to correct on both opening/accepting cases, extended case to cover it 13:46 < ariard> BlueMatt: if you're gonna expose something only for fuzzing, can you #[cfg(feature = "fuzztarget")]? what's PR are you talking about ? 13:46 -!- jtimon [~quassel@109.164.158.146.dynamic.jazztel.es] has joined #rust-bitcoin 13:48 < BlueMatt> 348 13:48 < BlueMatt> the second commit 13:49 < BlueMatt> https://github.com/rust-bitcoin/rust-lightning/pull/348/files#diff-9dc9910c41d9612ff2bf35f2c2b0e6e8R62 14:07 < ariard> I see, corrected 14:24 -!- mol [~molly@unaffiliated/molly] has joined #rust-bitcoin 14:39 < BlueMatt> ariard: can you take a look at https://github.com/rust-bitcoin/rust-lightning/pull/353 so we can take it? 15:38 -!- molly [~molly@unaffiliated/molly] has joined #rust-bitcoin 15:39 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:40 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 268 seconds] 18:18 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 18:34 -!- TamasBlummer1 [~Thunderbi@p200300DD67126481E5D8FA683872F3CF.dip0.t-ipconnect.de] has joined #rust-bitcoin 18:36 -!- TamasBlummer [~Thunderbi@p200300DD671264900C9FE453819C5FF6.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 18:36 -!- TamasBlummer1 is now known as TamasBlummer 19:32 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 19:32 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin 20:16 < ariard> BlueMatt: done, only blocker I'm just not sure about starting_time being part of channel keys derivation 20:41 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 248 seconds] 21:14 -!- jtimon [~quassel@109.164.158.146.dynamic.jazztel.es] has quit [Quit: gone] 21:22 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 22:31 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-jvovpxbkcmpnwiud] has quit [Quit: Connection closed for inactivity] --- Log closed Tue Jul 23 00:00:18 2019