--- Log opened Tue Jul 23 00:00:18 2019
00:25 < stevenroose> andytoshi: and it wouldn't be worth it trying to make our Transaction compatible? Was the reason because it breaks an exact roundtrip which breaks fuzzing?
00:28 < stevenroose> andytoshi: also, anything I can help with review/rebase for the next rust-bitcoin release? I'm very eager to start using Amount :)
02:47 < stevenroose> Is there a specific reason why secp256k1's SecretKey and PublicKey don't have hex serdes?
03:01 < stevenroose> Apparently SecretKey had because it was an array newtype, but public key didn't have..
03:01 < stevenroose> https://github.com/rust-bitcoin/rust-secp256k1/pull/133
04:35 -!- mauz555 [~mauz555@185.126.229.114] has joined #rust-bitcoin
05:08 -!- mauz555 [~mauz555@185.126.229.114] has quit []
05:18 < stevenroose> Is there a trivial way to go from a &[T] or Vec<T> to a &[&T]?
05:18 < stevenroose> I'm finding only &t.iter().collect::<Vec<_>>()
05:48 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ijbjmbptmkvlbchy] has joined #rust-bitcoin
06:37 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
07:14 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
07:20 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has quit [Quit: ZNC 1.6.6+deb1ubuntu0.2 - http://znc.in]
07:21 -!- instagibbs [~instagibb@pool-100-15-121-126.washdc.fios.verizon.net] has joined #rust-bitcoin
07:25 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
08:02 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
08:14 < andytoshi> stevenroose: no, it's not worth it to make us "compatible" with core's transaction
08:14 < andytoshi> core's transactions don't round trip
08:14 < andytoshi> so they're not even compatible with themselves
08:15 < andytoshi> stevenroose: i'm pretty sure both secretkey and publickey have had hex serdes for a ong time
08:15 < andytoshi> what version are you on?
08:23 < stevenroose> 0.3.0, but I checked master and didn't have it there for publickey, secretkey had (becaues of the newtype macro). I PRd it but something failed to build, looking at the Travis.
08:26 < stevenroose> andytoshi: ok that PR is turning green now: https://github.com/rust-bitcoin/rust-secp256k1/pull/133
08:47 < andytoshi> stevenroose: btw why do you need this?
08:47 < andytoshi> bitcoin::PublicKey has hex serde impl
08:48 < andytoshi> (but thank you! utack except spacing nit)
08:50 < stevenroose> andytoshi: yeah using this for liquid_rpc
08:51 < andytoshi> doesn't liquid use bitcoin publickeys?
09:02 < BlueMatt> ariard: do you (or anyone else here working on rust-lightning) want to give a talk at the lightning conference in october in berlin?
09:02 < BlueMatt> I'm gonna be in hawaii with the gf at the time, sadly
09:26 < BlueMatt> ariard: thanks. See it now?
09:27 < andytoshi> looks like travis/windows is not working right now?
09:46 -!- reallll [~belcher@unaffiliated/belcher] has joined #rust-bitcoin
09:50 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds]
09:54 -!- reallll is now known as belcher
10:56 < ariard> BlueMatt: answered back, still seed comment could be clearer, sorry with that, but I guess that could be a huge painpoint for users
10:57 < ariard> BlueMatt: well that would be good for rust-lightning showing up there, so I'm okay to give a talk
10:58 < ariard> and berlin is almost next-door for me
10:58 < BlueMatt> right, is an easier trip than me
10:58 < BlueMatt> ariard: do you have a twitter?
10:58 < BlueMatt> ariard: right, yea, seed comment should be really clear, agreed
10:58 < BlueMatt> will tweak
11:04 < ariard> BlueMatt: not on twitter
11:04 < BlueMatt> ariard: I pm'd you his email
11:04 < BlueMatt> fulmo, that is
11:08 < ariard> cool, gonna to check that
11:20 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #rust-bitcoin
12:05 < ariard> BlueMatt: okay for #353, people are really warned at least
12:10 < BlueMatt> kool!
12:49 < BlueMatt> ariard: hmmm, I was expanding chanmon_fail_consistency to match https://github.com/rust-bitcoin/rust-lightning/issues/327 and got a deserialization failure of the channelmanager that I had just serialized
12:50 < BlueMatt> ariard: is it possible that the new channelmonitor updates broke round-trip serialization in some edge cases?
12:57 < BlueMatt> ariard: if you get a chance, can you look into https://github.com/rust-bitcoin/rust-lightning/pull/356 and figure out why that testcase is failing?
13:20 < andytoshi> can i have two acks on https://github.com/rust-bitcoin/rust-bitcoin/pull/265
13:20 < andytoshi> stevenroose: it looks like you wrote "ACK" ut didn't actually approve the pr
13:29 < ariard> BlueMatt: yep, I'm finishing #349 and fly on that next
13:31 < BlueMatt> ariard: oops, nevermind, its a bug in the test
13:31 < BlueMatt> my bad, sorry for the noise
13:31 < BlueMatt> andytoshi: remind me tonight and I'll do it again if no one else gets to it, looks good but have to actually read through it to ack
13:43 < andytoshi> cool, thanks!
15:16 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
18:34 -!- TamasBlummer1 [~Thunderbi@p200300DD67126447B9BF97D5482085BB.dip0.t-ipconnect.de] has joined #rust-bitcoin
18:36 -!- TamasBlummer [~Thunderbi@p200300DD67126481E5D8FA683872F3CF.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds]
18:36 -!- TamasBlummer1 is now known as TamasBlummer
18:38 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ijbjmbptmkvlbchy] has quit [Quit: Connection closed for inactivity]
19:04 < BlueMatt> andytoshi: ping
19:07 < BlueMatt> nvm
19:07 < BlueMatt> posted anyway
19:28 -!- DeanWeen [~dean@gateway/tor-sasl/deanguss] has joined #rust-bitcoin
19:47 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #rust-bitcoin
19:47 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving]
20:00 < ariard> BlueMatt: hmmm it turns out that in fact getting data_loss_protect right is a bit of plumbery in monitor
20:01 < ariard> specially giving monitor the my_current_per_commitment_point from channel_reestablish
20:01 < ariard> I would like to return both a channel_monitor update and an error from Channel::channel_reestablish()
20:02 < ariard> but I feel our way to handling errors is already gross enough
20:42 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-jzwnvoevrxrrshiu] has joined #rust-bitcoin
--- Log closed Wed Jul 24 00:00:19 2019