--- Log opened Tue Dec 10 00:00:33 2019 01:48 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has joined #rust-bitcoin 02:22 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has quit [Ping timeout: 252 seconds] 02:37 -!- midnight [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 248 seconds] 02:44 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #rust-bitcoin 02:50 -!- midnightmagic is now known as midnight 02:58 -!- jonatack [~jon@213.152.161.35] has joined #rust-bitcoin 03:11 -!- jonatack [~jon@213.152.161.35] has quit [Ping timeout: 240 seconds] 03:16 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 03:19 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has joined #rust-bitcoin 03:22 -!- belcher [~belcher@unaffiliated/belcher] has joined #rust-bitcoin 03:34 -!- Audra62Bogan [~Audra62Bo@ns334669.ip-5-196-64.eu] has joined #rust-bitcoin 05:18 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 260 seconds] 05:44 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 06:16 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:41d2:4cd5:91d1:305b] has joined #rust-bitcoin 06:18 -!- jonatack [~jon@54.76.13.109.rev.sfr.net] has quit [Ping timeout: 268 seconds] 06:20 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #rust-bitcoin 06:24 -!- dr-orlovsky [~dr-orlovs@194.230.155.171] has quit [Quit: My MacBook has gone to sleep. ZZZzzz...] 06:28 -!- mauz555 [~mauz555@2a01:e35:8ab1:dea0:41d2:4cd5:91d1:305b] has quit [] 06:34 -!- Kiminuo [~mix@141.98.103.86] has quit [Ping timeout: 250 seconds] 07:31 -!- nijynot [~nijynot@83-233-23-98.cust.bredband2.com] has quit [Ping timeout: 265 seconds] 07:33 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has quit [Ping timeout: 265 seconds] 07:39 -!- instagibbs [~instagibb@pool-71-178-191-230.washdc.fios.verizon.net] has joined #rust-bitcoin 08:16 -!- jonatack [~jon@2a01:e0a:53c:a200:bb54:3be5:c3d0:9ce5] has joined #rust-bitcoin 08:35 -!- nijynot [~nijynot@eduroam07.nat.wireless.lu.se] has joined #rust-bitcoin 09:11 -!- nijynot [~nijynot@eduroam07.nat.wireless.lu.se] has quit [Ping timeout: 240 seconds] 09:49 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 260 seconds] 09:49 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #rust-bitcoin 10:22 -!- Kiminuo [~mix@141.98.103.86] has joined #rust-bitcoin 11:32 -!- ppartyix [~mix@141.98.103.182] has joined #rust-bitcoin 11:33 -!- ppartyix [~mix@141.98.103.182] has quit [Client Quit] 11:33 -!- ppartyix [~mix@141.98.103.182] has joined #rust-bitcoin 11:35 -!- Kiminuo [~mix@141.98.103.86] has quit [Ping timeout: 240 seconds] 11:48 < andytoshi> stevenroose: can you quckly ack https://github.com/rust-bitcoin/rust-secp256k1/pull/187 11:48 < andytoshi> or anybody 12:19 -!- ppartyix [~mix@141.98.103.182] has quit [Quit: Leaving] 12:20 -!- Kiminuo [~mix@141.98.103.182] has joined #rust-bitcoin 12:20 < Kiminuo> https://github.com/rust-bitcoin/rust-bitcoin/pull/360 - anyone? 12:25 -!- Audra62Bogan [~Audra62Bo@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds] 12:25 -!- sanket1729 [~sanket172@72.36.89.11] has quit [Ping timeout: 250 seconds] 12:29 -!- sanket1729 [~sanket172@72.36.89.11] has joined #rust-bitcoin 12:46 < andytoshi> new rust-secp version out 12:46 < andytoshi> Kiminuo: heh sure, one sec 12:46 < instagibbs> Kiminuo, You might want to reword the PR title/text to let readers immediately know what you're solving, linking the issue directly in the opening comment 12:46 < instagibbs> just for future marketing purposes of PRs ;) 12:47 < Kiminuo> instagibbs, ok, i'll do better next time :) 12:48 < andytoshi> also when you change many 100s of files it's good to acknowledge and give an excuse :P 12:48 < andytoshi> anyway utACK, let me just run the fuzztests locally and i'll merge 12:51 < Kiminuo> Yeah, a description would make it more clear. It's clear when one read the issue but not without it 13:00 < Kiminuo> tx 13:01 < andytoshi> np 13:13 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 265 seconds] 14:49 -!- Kiminuo [~mix@141.98.103.182] has quit [Read error: Connection reset by peer] 17:21 -!- ccdle12 [5eadef37@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #rust-bitcoin 17:25 -!- ccdle12 [5eadef37@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection] 20:56 < ariard> Aleru: hey what's the state of #382, do you need help? I can still take it forward with my refactored branch 21:09 < Aleru> so unless I am mistaken I think the way that i had originnally written it (the stuff you pulled) deadlocks... do_read_event() waits for the lock which we already gave and wont get back 21:10 < Aleru> I sort re did it so it is different (but still similar) from what we had agreed upon when you reviewed it. 21:15 < Aleru> right now I need to write the test function for it though, If i remember correctly I think we previously thought I did not need to mess with the noise::state stuff... but I think we do b.c we cant encrpyt the message (ping) unless the noise state is brought to finished and the existing stuff apparently does not do that (create_network(), establish_ connection()) 21:17 < Aleru> I think I am going to re clone the branch and push the current changes so you can check it out? 21:20 < Aleru> this is sort of a nit but perhaps test_disconnect_peer() should not say that it brings a set of peers to noise::state::finished because i don't think it actually does 21:27 < Aleru> but in a less long winded way Yeah i could probably use some help w/ part of it :) I will go ahead and push the most up to date src to a cloned repo on my github account and DM you some details 22:39 < ariard> Aleru: Oh don't care about the noise state when you're writing test, no need to encrypt messages 22:39 < ariard> yes you can force push the current changes or open a new PR 22:40 < Aleru> hmm? so ping/pong messages are not encrypted? 22:40 < ariard> They are, but there is no such wire when you're writing a functional test 22:40 < ariard> we mock nodes, they are not real nodes 22:41 < ariard> you get the raw messages and pass it directly by calling API methods on other peer 22:42 < ariard> the test framework is a bit of a mess, I'm planning to refactor it in the coming days 23:01 -!- Kiminuo [~mix@141.98.103.126] has joined #rust-bitcoin --- Log closed Wed Dec 11 00:00:33 2019